From: Peter Zijlstra <peterz@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"H. Peter Anvin" <hpa@zytor.com>,
"David S.Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>,
Chandramouli Narayanan <mouli@linux.intel.com>,
Vinodh Gopal <vinodh.gopal@intel.com>,
James Guilford <james.guilford@intel.com>,
Wajdi Feghali <wajdi.k.feghali@intel.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/7] sched: add function nr_running_cpu to expose number of tasks running on cpu
Date: Mon, 14 Jul 2014 21:15:04 +0200 [thread overview]
Message-ID: <20140714191504.GO9918@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1405364908.2970.729.camel@schen9-DESK>
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
On Mon, Jul 14, 2014 at 12:08:28PM -0700, Tim Chen wrote:
> On Mon, 2014-07-14 at 20:17 +0200, Peter Zijlstra wrote:
> > Your multi-buffer thing isn't generic either, it seems lmiited to sha1.
>
> We actually have many other multi-buffer crypto algorithms already
> published for encryption and other IPSec usages. So
> multi-buffer algorithm is not just limited to SHA1.
> We hope to port those to the kernel crypto library eventually.
> http://www.intel.com/content/dam/www/public/us/en/documents/white-papers/fast-multi-buffer-ipsec-implementations-ia-processors-paper.pdf
That's all nice and such; but the code as I've seen in these patches is
very much sha1 specific. The mb part isn't separated out.
> > It does not reuse padata,
> padata tries to speed things up by parallelizing jobs to *multiple*
> cpus. Whereas multi-buffer tries to speed things up by speeding things
> up by using multiple data lanes in SIMD register in a *single* cpu.
> These two usages are complementary but not the same.
And if its single cpu, wth do you need that nr_running thing for another
cpu for?
Also, this difference wasn't clear to me.
I still loathe all the async work, because it makes a mockery of
accounting etc.. but that's a story for another day I suppose :-(
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-07-14 19:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1405074379.git.tim.c.chen@linux.intel.com>
2014-07-11 20:32 ` [PATCH v4 0/7] crypto: SHA1 multibuffer implementation Tim Chen
2014-07-11 20:32 ` [PATCH v4 1/7] crypto: SHA1 multibuffer crypto hash infrastructure Tim Chen
2014-07-11 20:32 ` [PATCH v4 2/7] crypto: SHA1 multibuffer algorithm data structures Tim Chen
2014-07-11 20:32 ` [PATCH v4 3/7] crypto: SHA1 multibuffer submit and flush routines for AVX2 Tim Chen
2014-07-11 20:32 ` [PATCH v4 4/7] crypto: SHA1 multibuffer crypto computation (x8 AVX2) Tim Chen
2014-07-11 20:33 ` [PATCH v4 5/7] crypto: SHA1 multibuffer scheduler Tim Chen
2014-07-11 20:33 ` [PATCH v4 6/7] sched: add function nr_running_cpu to expose number of tasks running on cpu Tim Chen
2014-07-12 9:25 ` Kirill Tkhai
2014-07-14 17:51 ` Tim Chen
2014-07-12 14:21 ` Tadeusz Struk
2014-07-14 23:51 ` Tim Chen
2014-07-14 10:16 ` Peter Zijlstra
2014-07-14 16:10 ` Tim Chen
2014-07-14 16:14 ` Peter Zijlstra
2014-07-14 17:05 ` Tim Chen
2014-07-14 18:17 ` Peter Zijlstra
2014-07-14 19:08 ` Tim Chen
2014-07-14 19:15 ` Peter Zijlstra [this message]
2014-07-14 19:50 ` Tim Chen
2014-07-15 9:50 ` Peter Zijlstra
2014-07-15 12:07 ` Peter Zijlstra
2014-07-15 12:59 ` Thomas Gleixner
2014-07-15 14:45 ` Mike Galbraith
2014-07-15 14:53 ` Peter Zijlstra
2014-07-15 18:06 ` Mike Galbraith
2014-07-15 19:03 ` Peter Zijlstra
2014-07-15 19:24 ` Mike Galbraith
2014-07-15 18:41 ` Tim Chen
2014-07-15 20:46 ` Thomas Gleixner
2014-07-15 18:40 ` Tim Chen
2014-07-15 18:40 ` Tim Chen
2014-07-15 13:36 ` Peter Zijlstra
2014-07-15 15:21 ` Tejun Heo
2014-07-15 16:37 ` Peter Zijlstra
2014-07-11 20:33 ` [PATCH v4 7/7] crypto: SHA1 multibuffer - flush the jobs early if cpu becomes idle Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714191504.GO9918@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=james.guilford@intel.com \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mouli@linux.intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vinodh.gopal@intel.com \
--cc=wajdi.k.feghali@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.