Re: [PATCH 5/5] wl18xx-target-scripts : Add new WiFi related scripts

[Denys Dmytriyenko <denys@ti.com>]

On Mon, Jul 14, 2014 at 06:04:09PM +0300, Yaniv Machani wrote:
> New scripts to ease the use of wifi modes-
>  Start/Stop - Station, AP, P2P and Multi Role.
>  Station connection scripts.
>  Driver load/unload.
> 
> Signed-off-by: Yaniv Machani <yanivma@ti.com>
> ---
>  .../packagegroup-arago-tisdk-connectivity.bb       |    1 +
>  .../wl18xx-target-scripts_r8.a9.14.bb              |   24 ++++++++++++++++++++
>  2 files changed, 25 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
>  create mode 100755 meta-arago-extras/recipes-connectivity/wl18xx-target-scripts/wl18xx-target-scripts_r8.a9.14.bb
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> old mode 100644
> new mode 100755
> index 7b3480c..4b8fb00
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
> @@ -24,6 +24,7 @@ WLAN_COMMON = "\
>      crda \
>      hostap-daemon-wl18xx \
>      ti-wifi-utils-wl18xx \
> +    wl18xx-target-scripts \
>  "
>  
>  # netperf has non-standard license, needs verifying
> diff --git a/meta-arago-extras/recipes-connectivity/wl18xx-target-scripts/wl18xx-target-scripts_r8.a9.14.bb b/meta-arago-extras/recipes-connectivity/wl18xx-target-scripts/wl18xx-target-scripts_r8.a9.14.bb
> new file mode 100755
> index 0000000..404b7f6
> --- /dev/null
> +++ b/meta-arago-extras/recipes-connectivity/wl18xx-target-scripts/wl18xx-target-scripts_r8.a9.14.bb
> @@ -0,0 +1,24 @@
> +DESCRIPTION = "Scripts and configuration files for TI wireless drivers"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://README;beginline=1;endline=21;md5=b8d6a0865f50159bf5c0d175d1f4a705"
> +
> +PR ="r1"
> +PR_append = "+gitr${SRCPV}"

Can be a single assignment of PR variable instead of 2.


> +
> +# Tag: ol_r8.a9.14
> +SRCREV = "4d9f47235501fb2c665b6336a54e0ba152e8e941"
> +BRANCH = "sitara-mbss"
> +SRC_URI = "git://git.ti.com/wilink8-wlan/wl18xx-target-scripts.git;protocol=git;branch=${BRANCH}"
> +
> +S = "${WORKDIR}/git"
> +
> +
> +do_install() {
> +	install -d ${D}/usr/share/wl18xx/
> +
> +    scripts=`find ./ -type f -name "*\.sh"`
> +    for s in $scripts
> +    do
> +        install -m 0755 $s ${D}/usr/share/wl18xx/
> +    done

Looks like there's some indentation problem in do_install function - the first 
line is indented differently. Make sure to use consistent indentation - either 
tabs or spaces for shell functions and only spaces for python functions.

Also, please use ${datadir} instead ofhardcoding /usr/share


> +}
> -- 
> 1.7.9
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago