From: Peter Zijlstra <peterz@infradead.org>
To: David Rientjes <rientjes@google.com>
Cc: Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Stephane Eranian <eranian@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] x86, perf: avoid spamming kernel log for bts buffer failure
Date: Tue, 15 Jul 2014 10:53:42 +0200 [thread overview]
Message-ID: <20140715085342.GR9918@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1407141633190.4920@chino.kir.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On Mon, Jul 14, 2014 at 04:33:47PM -0700, David Rientjes wrote:
> On Mon, 30 Jun 2014, David Rientjes wrote:
>
> > It's unnecessary to excessively spam the kernel log anytime the BTS buffer
> > cannot be allocated, so make this allocation __GFP_NOWARN.
> >
> > The user probably will want to at least find some artifact that the
> > allocation has failed in the past, probably due to fragmentation because
> > of its large size, when it's not allocated at bootstrap. Thus, add a
> > WARN_ONCE() so something is left behind for them to understand why perf
> > commnads that require PEBS is not working properly.
> >
> > Signed-off-by: David Rientjes <rientjes@google.com>
>
> Peter, would you like to ack this? Trying to get this merged in time for
> the next merge window.
I've queued it; still don't like it though.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-07-15 8:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 23:04 [patch] x86, perf: avoid spamming kernel log for bts buffer failure David Rientjes
2014-07-01 9:34 ` Peter Zijlstra
2014-07-02 13:16 ` Stephane Eranian
2014-07-02 13:31 ` Peter Zijlstra
2014-07-02 13:38 ` Stephane Eranian
2014-07-02 14:54 ` Peter Zijlstra
2014-07-02 23:30 ` David Rientjes
2014-07-14 23:33 ` David Rientjes
2014-07-15 8:53 ` Peter Zijlstra [this message]
2014-07-16 19:21 ` [tip:perf/urgent] perf/x86/intel: Avoid spamming kernel log for BTS " tip-bot for David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715085342.GR9918@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rientjes@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.