From: Sam Ravnborg <sam@ravnborg.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
lkml <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH 35/38] unicore32: clean-up uapi Kbuild file
Date: Tue, 15 Jul 2014 13:07:30 +0200 [thread overview]
Message-ID: <20140715110730.GA3690@ravnborg.org> (raw)
In-Reply-To: <53C50840.2020204@imgtec.com>
Hi James.
> > +# Wapper from asm-generic
> > generic-y += kvm_para.h
> >
>
> You dropped the generic-y += kvm_para.h for arm64 & c6x, but not for
> unicore, avr32 & ia64 patch, which seems a bit inconsistent. Was there
> some reason behind that?
I was fooling around with kvm_para.h and in both cases dropping
them was wrong.
kvm_para.h shows the current nightmare when you want to add a header
file that for most architectures has a generic implementation, but
in a few cases have a dedicated implementation.
This is the same point that Arnd raises.
I will fix it up so kvm_para.h is again specified for arm64 + c6x.
And then will address the whole mess later if I manage to come up
with something that is acceptable (simple enough).
Thanks for the review!
Sam
next prev parent reply other threads:[~2014-07-15 11:07 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 15:06 [RFC PATCH 0/38] clean-up uapi + asm-generic Kbuild files Sam Ravnborg
2014-07-14 15:08 ` [PATCH 01/38] cris: fix headers_install Sam Ravnborg
2014-07-14 15:08 ` [PATCH 02/38] openrisc: drop ucontext from list exported headers Sam Ravnborg
2014-07-14 15:08 ` Sam Ravnborg
2014-07-14 15:08 ` [PATCH 03/38] hexagon: " Sam Ravnborg
2014-07-28 16:19 ` rkuo
2014-07-14 15:08 ` [PATCH 04/38] score: drop irrelevant assignment from Kbuild file Sam Ravnborg
2014-07-15 13:57 ` Lennox Wu
2014-07-14 15:08 ` [PATCH 05/38] tile: clean up Kbuild files Sam Ravnborg
2014-07-17 19:41 ` Chris Metcalf
2014-07-14 15:08 ` [PATCH 06/38] x86: clean-up Kbuild file - drop unused assignments Sam Ravnborg
2014-07-14 22:50 ` H. Peter Anvin
2014-07-14 15:08 ` [PATCH 07/38] Delete unused Kbuild files in include/* Sam Ravnborg
2014-07-15 9:06 ` James Hogan
2014-07-15 9:19 ` Sam Ravnborg
2014-07-14 15:08 ` [PATCH 08/38] kbuild: drop support for non uapi Kbuild files in headers_install Sam Ravnborg
2014-07-14 15:08 ` [PATCH 09/38] uapi: check for optional files which are generated Sam Ravnborg
2014-07-14 15:08 ` [PATCH 10/38] uapi: drop obsolete logic for generated headers Sam Ravnborg
2014-07-14 15:08 ` [PATCH 11/38] alpha: clean-up uapi Kbuild file Sam Ravnborg
2014-07-14 15:08 ` [PATCH 12/38] arm: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 13/38] arm64: " Sam Ravnborg
2014-07-14 17:02 ` Catalin Marinas
2014-07-15 10:14 ` James Hogan
2014-07-14 15:08 ` [PATCH 14/38] avr32: " Sam Ravnborg
2014-07-14 17:53 ` Hans-Christian Egtvedt
2014-07-14 15:08 ` [PATCH 15/38] blackfin: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 16/38] c6x: " Sam Ravnborg
2014-07-14 20:40 ` Mark Salter
2014-07-14 15:08 ` [PATCH 17/38] cris: " Sam Ravnborg
2014-08-11 5:35 ` Mikael Starvik
2014-09-03 11:23 ` Jesper Nilsson
2014-07-14 15:08 ` [PATCH 18/38] frv: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 19/38] hexagon: " Sam Ravnborg
2014-07-28 16:19 ` rkuo
2014-07-14 15:08 ` [PATCH 20/38] ia64: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 21/38] m32r: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 22/38] m68k: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 23/38] metag: " Sam Ravnborg
[not found] ` <1405350546-28467-23-git-send-email-sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2014-07-15 9:22 ` James Hogan
2014-07-15 9:22 ` James Hogan
2014-07-14 15:08 ` [PATCH 24/38] microblaze: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 25/38] mips: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 26/38] mn10300: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 27/38] openrisc: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 28/38] parisc: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 29/38] powerpc: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 30/38] s390: " Sam Ravnborg
2014-07-14 15:08 ` [PATCH 31/38] score: " Sam Ravnborg
2014-07-18 15:19 ` Lennox Wu
2014-07-14 15:09 ` [PATCH 32/38] sh: " Sam Ravnborg
2014-07-14 15:09 ` [PATCH 33/38] sparc: " Sam Ravnborg
2014-07-14 20:02 ` David Miller
2014-07-14 15:09 ` [PATCH 34/38] tile: " Sam Ravnborg
2014-07-17 19:44 ` Chris Metcalf
2014-07-14 15:09 ` [PATCH 35/38] unicore32: " Sam Ravnborg
2014-07-15 10:53 ` James Hogan
2014-07-15 11:07 ` Sam Ravnborg [this message]
2014-07-14 15:09 ` [PATCH 36/38] x86: " Sam Ravnborg
2014-07-14 22:52 ` H. Peter Anvin
2014-07-14 15:09 ` [PATCH 37/38] xtensa: " Sam Ravnborg
2014-07-14 15:09 ` [PATCH 38/38] asm-generic: introduc Kbuild.generic Sam Ravnborg
2014-07-15 7:03 ` Arnd Bergmann
2014-07-17 10:38 ` Sam Ravnborg
2014-07-17 10:50 ` Arnd Bergmann
2014-08-11 5:35 ` [PATCH 01/38] cris: fix headers_install Mikael Starvik
2014-09-03 11:22 ` Jesper Nilsson
2014-07-14 15:34 ` [RFC PATCH 0/38] clean-up uapi + asm-generic Kbuild files Arnd Bergmann
2014-07-14 22:14 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715110730.GA3690@ravnborg.org \
--to=sam@ravnborg.org \
--cc=arnd@arndb.de \
--cc=gxt@mprc.pku.edu.cn \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.