From: Theodore Ts'o <tytso@mit.edu>
To: "Wilcox, Matthew R" <matthew.r.wilcox@intel.com>
Cc: Zhang Zhen <zhenzhang.zhang@huawei.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"wangnan0@huawei.com" <wangnan0@huawei.com>,
"Zwisler, Ross" <ross.zwisler@intel.com>
Subject: Re: [PATCH v2] ext4: remove readpage() check up for mmap file
Date: Tue, 15 Jul 2014 12:16:03 -0400 [thread overview]
Message-ID: <20140715161603.GB1491@thunk.org> (raw)
In-Reply-To: <100D68C7BA14664A8938383216E40DE0407A9B2C@FMSMSX114.amr.corp.intel.com>
On Tue, Jul 15, 2014 at 02:16:40PM +0000, Wilcox, Matthew R wrote:
> Are you sure about the origins of that check, Ted? It's not there
> in current ext2, and current XIP code calls the generic
> xip_file_mmap() method, not an ext2/4 specific one.
That was my memory, but I admit I haven't gone diving into the pre-git
linux-history tree to make sure.....
But in any case, the only possible potential conflict would have been
on the XIP patch set, and it doesn't seem to be an issue there.
(BTW, what's the current status on the XIP patch set? I admit I've
gotten too busy to track its status lately. There were a bunch of
comments from mm and core vfs folks, but that was a while ago. What's
still left to be resolved at this point?)
- Ted
prev parent reply other threads:[~2014-07-15 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1404368274-10404-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-07-03 6:18 ` [PATCH v2] ext4: remove readpage() check up for mmap file Zhang Zhen
2014-07-15 13:43 ` Theodore Ts'o
2014-07-15 14:16 ` Wilcox, Matthew R
2014-07-15 16:16 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715161603.GB1491@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
--cc=ross.zwisler@intel.com \
--cc=wangnan0@huawei.com \
--cc=zhenzhang.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.