All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192ee: Fix setting highest n rate
Date: Tue, 15 Jul 2014 12:06:34 -0700	[thread overview]
Message-ID: <20140715190634.GA16330@kroah.com> (raw)
In-Reply-To: <1405396592-909-1-git-send-email-Larry.Finger@lwfinger.net>

On Mon, Jul 14, 2014 at 10:56:32PM -0500, Larry Finger wrote:
> Commit 4fb6a37c3f94c1cb4b828bfcc4347771e1628f88 by Andrey Utkin
> <andrey.krieger.utkin@gmail.com> and entitled "staging: rtl8192ee:
> "Correct bitmask in comparsion" fixed what appeared to be a typo. After
> consultation with the Realtek engineers, merely testing for a 2T2R device
> is sufficient to ensure that the TX MCS map will equal 0x0c, thus the second
> test can be ignored.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>  drivers/staging/rtl8192ee/base.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192ee/base.c b/drivers/staging/rtl8192ee/base.c
> index 71ed12e..b8b897a 100644
> --- a/drivers/staging/rtl8192ee/base.c
> +++ b/drivers/staging/rtl8192ee/base.c
> @@ -826,8 +826,7 @@ static u8 _rtl_get_vht_highest_n_rate(struct ieee80211_hw *hw,
>  	u8 hw_rate;
>  	u16 map = le16_to_cpu(sta->vht_cap.vht_mcs.tx_mcs_map);
>  
> -	if ((get_rf_type(rtlphy) == RF_2T2R) &&
> -	    (map & 0x000c) != 0x000c) {
> +	if ((get_rf_type(rtlphy) == RF_2T2R) {

I don't think you test built this change :(

      reply	other threads:[~2014-07-15 19:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15  3:56 [PATCH] staging: rtl8192ee: Fix setting highest n rate Larry Finger
2014-07-15 19:06 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140715190634.GA16330@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.