From: Jonathan Nieder <jrnieder@gmail.com>
To: Ronnie Sahlberg <sahlberg@google.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] refs.c: add a public is_branch function
Date: Tue, 15 Jul 2014 16:20:51 -0700 [thread overview]
Message-ID: <20140715232051.GL12427@google.com> (raw)
In-Reply-To: <1405465358-27054-2-git-send-email-sahlberg@google.com>
Ronnie Sahlberg wrote:
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> ---
> builtin/fsck.c | 5 -----
> refs.c | 2 +-
> refs.h | 2 ++
> 3 files changed, 3 insertions(+), 6 deletions(-)
Makes sense -- thanks. (This is an old one: v1.5.4-rc4~27
(2008-01-15), v1.5.4-rc4~30 (2008-01-15). Most of the running time of
fsck is per-object, not per-ref, so maintainability here seems worth
the performance cost.)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2014-07-15 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 23:02 [PATCH] remove duplicate of is_branch Ronnie Sahlberg
2014-07-15 23:02 ` [PATCH] refs.c: add a public is_branch function Ronnie Sahlberg
2014-07-15 23:20 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715232051.GL12427@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sahlberg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.