From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46119)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1X7NtC-0006dt-Do
	for qemu-devel@nongnu.org; Wed, 16 Jul 2014 08:00:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1X7Nt7-0006lB-J6
	for qemu-devel@nongnu.org; Wed, 16 Jul 2014 08:00:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39568)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1X7Nt7-0006l5-AO
	for qemu-devel@nongnu.org; Wed, 16 Jul 2014 08:00:45 -0400
Date: Wed, 16 Jul 2014 09:00:28 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20140716120028.GA8761@amt.cnet>
References: <CABYiri8_naTkFgVJEwy9O52gRYHTVGwo-6sH-r+0FOFPf0Zm8w@mail.gmail.com>
	<20140715050318.GD26186@grmbl.mre>
	<CABYiri86MPATuKNmH489-DL3e=7=4XYi4ZVq+r=82duh1240ng@mail.gmail.com>
	<CABYiri_Jb+cAty591-cmqsgxbZne-9BZeDwDOFdAm1gaKtpgzQ@mail.gmail.com>
	<20140715210948.GA20036@amt.cnet> <53C62B34.60505@beyond.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <53C62B34.60505@beyond.pl>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcin =?utf-8?Q?Gibu=C5=82a?= <m.gibula@beyond.pl>
Cc: Amit Shah <amit.shah@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andrey Korolyov <andrey@xdel.ru>, Fam Zheng <famz@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Wed, Jul 16, 2014 at 09:35:16AM +0200, Marcin Gibu=C5=82a wrote:
> >Andrey,
> >
> >Can you please provide instructions on how to create reproducible
> >environment?
> >
> >The following patch is equivalent to the original patch, for
> >the purposes of fixing the kvmclock problem.
> >
> >Perhaps it becomes easier to spot the reason for the hang you are
> >experiencing.
>=20
> Marcelo,
>=20
> the original reason for patch adding cpu_synchronize_all_states()
> there was because this bug affected non-migration operations as well
> -
> http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00472.html.
>=20
> Won't moving it only to migration code break these things again?

Yes - its just for debug purposes.