From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Michalis Pappas <mpappas@fastmail.fm>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gdm72xx: conditionally compile debug code
Date: Wed, 16 Jul 2014 15:57:42 -0700 [thread overview]
Message-ID: <20140716225742.GA2983@kroah.com> (raw)
In-Reply-To: <1405550769.6381.17.camel@joe-AO725>
On Wed, Jul 16, 2014 at 03:46:09PM -0700, Joe Perches wrote:
> On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote:
> > On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote:
> []
> > > Ok, I agree on the ifdef stuff. My question was regarding your
> > > suggestion above to replace print_hex_debug() with dev_dbg()
> >
> > You want the device name/id/label to show up as well, that is why you
> > should use the dev_dbg() version, print_hex_dump() does not take a
> > struct device *, so the user has no idea what device this data was
> > coming from.
>
> But Michalis could alway add something like:
> dev_hex_dump()
> and
> dev_dbg_hex_dump()
>
With the built-in "hex dump primitive" in printk(), why would you want
to do that? You shouldn't be putting more than 64 bytes in a single
printk message in a hex dump, if you want to do more, use debugfs.
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-16 22:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 13:00 [PATCH] staging: gdm72xx: remove unused code Michalis Pappas
2014-07-01 13:00 ` [PATCH] staging: gdm72xx: conditionally compile debug code Michalis Pappas
[not found] ` <CAC5Y2nPGyByqLEM1Go6Pxpb6MhiJy2Fvu=eEz6ak24gMhayk=A@mail.gmail.com>
2014-07-01 16:40 ` Michalis Pappas
[not found] ` <CAC5Y2nOvJ2=u7-T53kHd50AfQ7Mo_U4qvD_=si9=NSr_q0w3NA@mail.gmail.com>
2014-07-03 17:27 ` Michalis Pappas
2014-07-09 18:51 ` Greg KH
2014-07-09 19:52 ` Michalis Pappas
2014-07-09 20:24 ` Greg KH
2014-07-16 20:40 ` Michalis Pappas
2014-07-16 20:50 ` Greg KH
2014-07-16 22:03 ` Michalis Pappas
2014-07-16 22:10 ` Greg KH
2014-07-16 22:46 ` Joe Perches
2014-07-16 22:57 ` Greg KH [this message]
2014-07-17 0:19 ` Joe Perches
2014-07-01 13:00 ` [PATCH] staging: gdm72xx: move T_CAPABILITY bit definitions to hci.h Michalis Pappas
2014-07-01 15:37 ` Ben Chan
2014-07-01 16:25 ` Michalis Pappas
2014-07-02 10:18 ` [PATCH V2] staging: gdm72xx: move T_CAPABILITY " Michalis Pappas
2014-07-09 10:26 ` Dan Carpenter
2014-07-09 18:24 ` Michalis Pappas
2014-07-09 18:31 ` [PATCH v3] " Michalis Pappas
2014-07-09 18:57 ` Greg KH
2014-07-09 19:21 ` [PATCH v4] " Michalis Pappas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716225742.GA2983@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpappas@fastmail.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.