From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES
Date: Thu, 17 Jul 2014 18:52:31 +0200 [thread overview]
Message-ID: <20140717165231.GA3737@free.fr> (raw)
In-Reply-To: <1405609578-28052-1-git-send-email-anaumann@ultratronik.de>
Andreas, All,
On 2014-07-17 17:06 +0200, Andreas Naumann spake thusly:
> The cp helperscript expects a filename as target, but just the folder name was given.
This is mising your Signed-off-by line. Care to just reply to your
initial mail to add it, please?
Otherwise:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/pkg-download.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index 7f208d5..118591c 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -206,7 +206,7 @@ endef
> define DOWNLOAD_LOCALFILES
> test -e $(DL_DIR)/$(2) || \
> $(EXTRA_ENV) support/download/cp $(call stripurischeme,$(call qstrip,$(1))) \
> - $(DL_DIR) && \
> + $(DL_DIR)/$(2) && \
> $(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
> endef
>
> --
> 1.8.3.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-07-17 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 15:06 [Buildroot] [PATCH] pkg-infra: Fix DOWNLOAD_LOCALFILES Andreas Naumann
2014-07-17 16:52 ` Yann E. MORIN [this message]
2014-07-18 7:12 ` Andreas Naumann
2014-07-18 16:46 ` Yann E. MORIN
2014-07-18 18:02 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717165231.GA3737@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.