From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] u-boot: Allow to specify a list of patches
Date: Thu, 17 Jul 2014 19:23:31 +0200 [thread overview]
Message-ID: <20140717172331.GD3737@free.fr> (raw)
In-Reply-To: <53C77FC8.6060303@mind.be>
Arnout, All,
On 2014-07-17 09:48 +0200, Arnout Vandecappelle spake thusly:
> On 17/07/14 06:52, Thomas De Schampheleire wrote:
> > Arnout Vandecappelle <arnout@mind.be> schreef:
> >> On 15/07/14 22:13, Yann E. MORIN wrote:
> >>> The more I think about it, the more I find our policy to require
> >>> PKG-prefixed patches to be really cumbersome, since the patches already
> >>> are in a subdir named PKG/
> >>>
> >>> Of course, we're enforcing this naming scheme in BR2_GLOBAL_PATCH_DIR to
> >>> be in sync with what we do for our bundled patches.
> >>>
> >>> But still, if patches were just named NNNN-title.patch, that would be as
> >>> efficient at sorting the patches. The PKG- prefix is not really
> >>> required, and indeed can cause some troubles with some use-cases, such
> >>> as yours.
> >>>
> >>> Thomas, was there a specific reason we wanted the patches to be
> >>> PKG-prefixed? If not, would it make sense to just accept patches without
> >>> a PKG-prefix?
> >>
> >> Er, we don't... We require this specific naming scheme for contributed
> >> packages, but the code itself just takes *.patch.
> >
> > Yes sure, it's a convention only, but the question is: why did we include the package name in the convention?
>
> I think it's purely historical. And I think it never was required for patches
> in a <pkgname> subdir.
So we could change the manual to not require patches to be PKG-prefixed?
As long as they are number-prefixed, that's all we need, right?
So, Ezequiel's patch is really no longer needed, and his use-case to use
git-formatted patches is already covered, right?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-07-17 17:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 18:26 [Buildroot] [PATCH] u-boot: Allow to specify a list of patches Ezequiel Garcia
2014-07-15 18:53 ` Thomas Petazzoni
2014-07-15 19:49 ` Ezequiel García
2014-07-15 20:13 ` Yann E. MORIN
2014-07-15 20:35 ` Thomas Petazzoni
2014-07-16 5:21 ` Thomas De Schampheleire
2014-07-16 22:23 ` Arnout Vandecappelle
2014-07-17 4:52 ` Thomas De Schampheleire
2014-07-17 7:48 ` Arnout Vandecappelle
2014-07-17 17:23 ` Yann E. MORIN [this message]
2014-07-17 23:20 ` Arnout Vandecappelle
2014-07-21 19:55 ` Ezequiel García
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140717172331.GD3737@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.