From: Christoph Hellwig <hch@lst.de>
To: Robert Elliott <elliott@hp.com>
Cc: axboe@kernel.dk, abhijit.mahajan@avagotech.com,
kmo@datarainc.com, nagalakshmi.nandigama@avagotech.com,
asamymuthupa@micron.com, snitzer@redhat.com,
JBottomley@parallels.com, relliott@beardog.cce.hp.com,
sreekanth.reddy@avagotech.com,
praveen.krishnamoorthy@avagotech.com, agordeev@redhat.com,
scameron@beardog.cce.hp.com, tom.leiming@gmail.com,
sbradshaw@micron.com, hch@lst.de, m@bjorling.me,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/3] mpt3sas, mpt2sas: fix scsi_add_host error handling problems in _scsih_probe
Date: Fri, 18 Jul 2014 11:46:49 +0200 [thread overview]
Message-ID: <20140718094649.GC2121@lst.de> (raw)
In-Reply-To: <20140717193926.1924.21344.stgit@beardog.cce.hp.com>
On Thu, Jul 17, 2014 at 02:39:30PM -0500, Robert Elliott wrote:
> In _scsih_probe, propagate the return value from scsi_add_host.
> In mpt3sas, avoid calling list_del twice if that returns an
> error, which causes list_del corruption warnings if an error
> is returned.
>
> Tested with blk-mq and scsi-mq patches to properly cleanup
> from and propagate blk_mq_init_rq_map errors.
>
> Signed-off-by: Robert Elliott <elliott@hp.com>
Looks good. It would be even better if we'd have proper error values
returned from mpt2/3sas_base_attach as well.
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2014-07-18 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 19:38 [PATCH 0/3] blk-mq: blk_mq_init_rq_map error handling Robert Elliott
2014-07-17 19:39 ` [PATCH 1/3] blk-mq: cleanup after blk_mq_init_rq_map failures Robert Elliott
2014-07-18 9:45 ` Christoph Hellwig
2014-07-17 19:39 ` [PATCH 2/3] blk-mq: pass along blk_mq_alloc_tag_set return values Robert Elliott
2014-07-18 9:45 ` Christoph Hellwig
2014-07-17 19:39 ` [PATCH 3/3] mpt3sas, mpt2sas: fix scsi_add_host error handling problems in _scsih_probe Robert Elliott
2014-07-18 9:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718094649.GC2121@lst.de \
--to=hch@lst.de \
--cc=JBottomley@parallels.com \
--cc=abhijit.mahajan@avagotech.com \
--cc=agordeev@redhat.com \
--cc=asamymuthupa@micron.com \
--cc=axboe@kernel.dk \
--cc=elliott@hp.com \
--cc=kmo@datarainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m@bjorling.me \
--cc=nagalakshmi.nandigama@avagotech.com \
--cc=praveen.krishnamoorthy@avagotech.com \
--cc=relliott@beardog.cce.hp.com \
--cc=sbradshaw@micron.com \
--cc=scameron@beardog.cce.hp.com \
--cc=snitzer@redhat.com \
--cc=sreekanth.reddy@avagotech.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.