All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] Add $$(PKG)_AUTORECONF_ENV argument to autotools package autoreconf command to allow environment variables to be used.
Date: Fri, 18 Jul 2014 10:51:54 +0200	[thread overview]
Message-ID: <20140718105154.72c05a4f@free-electrons.com> (raw)
In-Reply-To: <1405672963-16069-1-git-send-email-rick.taylor@cassidian.com>

Dear Rick Taylor,

On Fri, 18 Jul 2014 09:42:41 +0100, Rick Taylor wrote:
> Signed-off-by: Rick Taylor <rick.taylor@cassidian.com>
> ---
>  package/pkg-autotools.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks. However, the commit log is not properly formatted. With git,
the commit log should have one line of less than ~80 characters that
summarizes the commit, then one empty new line, and then more details.
Also, in Buildroot, we like when the commit title has a prefix that
identifies the area of the change. I.e, in your case, something like:

===
pkg-autotools: add support for <pkg>_AUTORECONF_ENV

This commit improves the autotools-package infrastructure to support a
<pkg>_AUTORECONF_ENV variable, which allows to pass addition variables
in the environment of the autoreconf execution. This is useful in the
situation where blabla blibli ...

Signed-off-by: ...
===

Could you update your commit log with this format?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2014-07-18  8:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18  8:42 [Buildroot] [PATCH 1/3] Add $$(PKG)_AUTORECONF_ENV argument to autotools package autoreconf command to allow environment variables to be used Rick Taylor
2014-07-18  8:42 ` [Buildroot] [PATCH 2/3] Update documentation of AUTORECONF_ENV Rick Taylor
2014-07-18  8:52   ` Thomas Petazzoni
2014-07-18  8:54   ` Thomas De Schampheleire
2014-07-18  9:16     ` Rick Taylor
2014-07-18  8:42 ` [Buildroot] [PATCH 3/3] Update documentation to clarify usage Rick Taylor
2014-07-18  8:52   ` Thomas Petazzoni
2014-07-18  8:51 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140718105154.72c05a4f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.