All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] python: fix termios build for xtensa
Date: Fri, 18 Jul 2014 16:30:49 +0300	[thread overview]
Message-ID: <20140718133049.GC4914@tarshish> (raw)
In-Reply-To: <CAMo8BfKRNBdfHreAzjT+4N6Fi81SKbSsCFZxpp3GCRgz9XhGYg@mail.gmail.com>

Hi Max,

On Fri, Jul 18, 2014 at 03:42:43PM +0400, Max Filippov wrote:
> On Fri, Jul 18, 2014 at 7:32 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> > The xtensa ioctls.h header references struct serial_multiport_struct that is
> > not defined in this header or included headers. ioctls.h also references
> > tty_struct that is not exported to userspace at all. Add a patch fixing these
> > issues.
> >
> > This is only a workaround as the real problem should be fixed in the kernel
> > (by removing all struct references like all other archs). But since we support
> > older kernel versions we'll have to carry this patch for some time.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/12b/12b5612828d7f1fc7d1f69fc01341d5a6e628db5/
> >
> > Cc: Max Filippov <jcmvbkbc@gmail.com>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  .../python-015-serial-ioctl-workaround.patch       | 23 ++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >  create mode 100644 package/python/python-015-serial-ioctl-workaround.patch
> 
> Thank you, Baruch.
> I'll send corresponding linux patches. I definitely saw this issue
> some time ago,
> but I couldn't find any trace of that ):

You mean commit b973b4c91be8f (xtensa: fix TIOCGSERIAL and TIOCSSERIAL 
definitions)? It solved part of the problem.

It seems most other architectures migrated to asm-generic/ioctls.h.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2014-07-18 13:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18  3:32 [Buildroot] [PATCH] python: fix termios build for xtensa Baruch Siach
2014-07-18 11:42 ` Max Filippov
2014-07-18 13:30   ` Baruch Siach [this message]
2014-07-19  0:06     ` Max Filippov
2014-07-18 18:04 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140718133049.GC4914@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.