From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330() Date: Fri, 18 Jul 2014 16:17:47 +0200 Message-ID: <20140718141747.GA23272@lst.de> References: <53C8DF7F.5060707@gmail.com> <53C8FD95.5020302@gmail.com> <20140718132104.GK27940@esperanza> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20140718132104.GK27940@esperanza> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-bounces-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org Errors-To: kernel-bounces-TuqUDEhatI4ANWPb/1PvSmm0pvjS0E/A@public.gmane.org To: Vladimir Davydov Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mailing-List fedora-kernel , poma , Linux Kernel list , James Bottomley , Paolo Bonzini , Christoph Lameter , Christoph Hellwig List-Id: linux-scsi@vger.kernel.org T24gRnJpLCBKdWwgMTgsIDIwMTQgYXQgMDU6MjE6MDRQTSArMDQwMCwgVmxhZGltaXIgRGF2eWRv diB3cm90ZToKPiBTbGFiIHdhcm5zLCBiZWNhdXNlIHRoZSBuYW1lIG9mIHRoZSBjYWNoZSBiZWlu ZyBjcmVhdGVkIGNvbnRhaW5zIHNwYWNlcy4KPiBUaGUgImJhZCIgY2FjaGUgaXMgY3JlYXRlZCBi eSBzY3NpX2dldF9ob3N0X2NtZF9wb29sLiBJdHMgbmFtZQo+IChwb29sLT5jbWRfbmFtZSkgaXMg aW5pdGlhbGl6ZWQgYnkgc2NzaV9hbGxvY19ob3N0X2NtZF9wb29sIGFzIGZvbGxvd3M6Cj4gCj4g CXBvb2wtPmNtZF9uYW1lID0ga2FzcHJpbnRmKEdGUF9LRVJORUwsICIlc19jbWQiLCBob3N0dC0+ bmFtZSk7Cj4gCj4gU28sIGlmIGhvc3R0LT5uYW1lIGNvbnRhaW5zIHNwYWNlcywgdGhlIGNhY2hl IG5hbWUgd2lsbCBhbHNvIGNvbnRhaW4KPiBzcGFjZXMgYW5kIHdlJ2xsIGdldCB0aGUgd2Fybmlu Zy4gQW5kIGhvc3R0LT5uYW1lIGNhbiBjb250YWluIHNwYWNlcywKPiBlLmcuIHZpcnRzY3NpX2hv c3RfdGVtcGxhdGVfc2luZ2xlLm5hbWU9IlZpcnRpbyBTQ1NJIEhCQSIuCgpPciBtaWdodCBub3Qg ZXZlbiBiZSBwcmVzZW50LiAgSSdsbCBzZW5kIGEgcGF0Y2ggdG8gcmVwbGFjZSBpdCB3aXRoCi0+ cHJvY19uYW1lLCB3aGljaCBtdXN0IG5vdCBjb250YWluIHNwYWNlcyBhbmQgaXMgZ2VuZXJhbGx5 IHNob3J0ZXIKYXMgd2VsbC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmtlcm5lbCBtYWlsaW5nIGxpc3QKa2VybmVsQGxpc3RzLmZlZG9yYXByb2plY3Qu b3JnCmh0dHBzOi8vYWRtaW4uZmVkb3JhcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXJu ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761945AbaGRORy (ORCPT ); Fri, 18 Jul 2014 10:17:54 -0400 Received: from verein.lst.de ([213.95.11.211]:49624 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964864AbaGRORw (ORCPT ); Fri, 18 Jul 2014 10:17:52 -0400 Date: Fri, 18 Jul 2014 16:17:47 +0200 From: Christoph Hellwig To: Vladimir Davydov Cc: poma , Linux Kernel list , Christoph Lameter , Mailing-List fedora-kernel , Christoph Hellwig , Paolo Bonzini , James Bottomley , linux-scsi@vger.kernel.org Subject: Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330() Message-ID: <20140718141747.GA23272@lst.de> References: <53C8DF7F.5060707@gmail.com> <53C8FD95.5020302@gmail.com> <20140718132104.GK27940@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140718132104.GK27940@esperanza> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote: > Slab warns, because the name of the cache being created contains spaces. > The "bad" cache is created by scsi_get_host_cmd_pool. Its name > (pool->cmd_name) is initialized by scsi_alloc_host_cmd_pool as follows: > > pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->name); > > So, if hostt->name contains spaces, the cache name will also contain > spaces and we'll get the warning. And hostt->name can contain spaces, > e.g. virtscsi_host_template_single.name="Virtio SCSI HBA". Or might not even be present. I'll send a patch to replace it with ->proc_name, which must not contain spaces and is generally shorter as well.