From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
subhransu.s.prusty@intel.com, lgirdwood@gmail.com
Subject: Re: [PATCH 7/7] ASoC: Intel: sst - add compressed ops handling
Date: Fri, 18 Jul 2014 19:53:39 +0530 [thread overview]
Message-ID: <20140718142339.GG1985@intel.com> (raw)
In-Reply-To: <20140718114823.GN17528@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 971 bytes --]
On Fri, Jul 18, 2014 at 12:48:23PM +0100, Mark Brown wrote:
> On Wed, Jul 09, 2014 at 02:57:55PM +0530, Vinod Koul wrote:
>
> > + if (codec->codec == SND_AUDIOCODEC_MP3) {
> > + codec->num_descriptors = 2;
> > + codec->descriptor[0].max_ch = 2;
> > + codec->descriptor[0].sample_rates[0] = 48000;
> > + codec->descriptor[0].sample_rates[1] = 44100;
> > + codec->descriptor[0].sample_rates[2] = 32000;
> > + codec->descriptor[0].sample_rates[3] = 16000;
> > + codec->descriptor[0].sample_rates[4] = 8000;
> > + codec->descriptor[0].num_sample_rates = 5;
> > + codec->descriptor[0].bit_rate[0] = 320; /* 320kbps */
> > + codec->descriptor[0].bit_rate[1] = 192;
> > + codec->descriptor[0].num_bitrates = 2;
> > + codec->descriptor[0].profiles = 0;
> > + codec->descriptor[0].modes = SND_AUDIOCHANMODE_MP3_STEREO;
> > + codec->descriptor[0].formats = 0;
>
> It'd be more idiomatic to copy a static variable.
will update...
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-07-18 14:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 9:27 [PATCH 0/8] ASoC: Intel: sst - add the merrifield DSP driver Vinod Koul
2014-07-09 9:27 ` [PATCH 1/7] ASoC: Intel: add sst shim register start-end variables Vinod Koul
2014-07-14 18:45 ` Mark Brown
2014-07-09 9:27 ` [PATCH 2/7] ASoC: Intel: mfld: add dsp error codes Vinod Koul
2014-07-14 18:45 ` Mark Brown
2014-07-09 9:27 ` [PATCH 3/7] ASoC: Intel: mrlfd - add generic parameter interface Vinod Koul
2014-07-14 18:46 ` Mark Brown
2014-07-15 5:25 ` Vinod Koul
2014-07-15 12:38 ` Mark Brown
2014-07-09 9:27 ` [PATCH 4/7] ASoC: Intel: mrfld - add the dsp sst driver Vinod Koul
2014-07-18 11:35 ` Mark Brown
2014-07-18 14:13 ` Vinod Koul
2014-07-18 16:59 ` Mark Brown
2014-07-19 6:31 ` Vinod Koul
2014-07-09 9:27 ` [PATCH 5/7] ASoC: Intel: sst: add power management handling Vinod Koul
2014-07-18 11:46 ` Mark Brown
2014-07-18 14:23 ` Vinod Koul
2014-07-18 17:14 ` Mark Brown
2014-07-19 6:37 ` Vinod Koul
2014-07-09 9:27 ` [PATCH 6/7] ASoC: Intel: sst: load firmware using async callback Vinod Koul
2014-07-09 9:27 ` [PATCH 7/7] ASoC: Intel: sst - add compressed ops handling Vinod Koul
2014-07-18 11:48 ` Mark Brown
2014-07-18 14:23 ` Vinod Koul [this message]
2014-07-09 9:27 ` [PATCH 0/8] ASoC: Intel: sst - add the merrifield DSP driver Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718142339.GG1985@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=subhransu.s.prusty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.