From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH RFC 00/10] dm-dedup: device-mapper deduplication target Date: Fri, 18 Jul 2014 10:44:23 -0400 Message-ID: <20140718144423.GB4762@redhat.com> References: <535ed0d2.0729e00a.4489.0c48@mx.google.com> <20140505182450.GA16456@redhat.com> <20140506134357.GA27331@vass-desktop> <20140718024336.GA1291@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Vasily Tarasov Cc: device-mapper development , Christoph Hellwig , ejt@redhat.com, Philip Shilane , Sonam Mandal , Erez Zadok , Mikulas Patocka List-Id: dm-devel.ids On Fri, Jul 18 2014 at 7:59am -0400, Vasily Tarasov wrote: > Hi Mike, > > Thanks for your initial reviewing steps! Here is what we plan to do: > > 1) Address your current comments Thanks, try to look at how the other DM targets have tables with arguments that have a fixed position (less flexible than name=value but tools like lvm2 benefit from the rigidity). > 2) Few people mentioned that our documentation need to be formatted > better and be more detailed. We'll address this. Yes, it could be more comprehensive. And it would be nice if it were updated to have the same kind of sections/flow that other targets' Documentation/device-mapper/ files have (e.g. cache.txt and thin-provisioning.txt). But overall the plan sounds great.