From: "Theodore Ts'o" <tytso@mit.edu>
To: Brent Cook <busterb@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] initial getrandom wrapper to provide getentropy for LibreSSL
Date: Fri, 18 Jul 2014 12:19:36 -0400 [thread overview]
Message-ID: <20140718161936.GA4877@thunk.org> (raw)
In-Reply-To: <1158B2FC-1289-4E10-8C99-F407123B0D01@gmail.com>
On Fri, Jul 18, 2014 at 08:09:52AM -0500, Brent Cook wrote:
> On Jul 18, 2014, at 1:49 AM, Brent Cook <busterb@gmail.com> wrote:
>
> > From: Brent Cook <bcook@openbsd.org>
> >
> > This is not a kernel patch, but rather an initial test of the API to see
> > how it might mesh LibreSSL's expectations for how getentropy works.
> >
> > It is a bit more code to carefully handle the extra return values, as
> > not reading enough bytes, because there is an unhandled EINTR, might
> > lead to an unseeded CSPRNG.
Take a look at the latest patch for getrandom. It contains a
suggested wrapper which should be sufficient for emulation of
OpenBSD's getentropy(), and a lot of discussion of when you don't need
to worry about getting the EINTR.
http://lists.openwall.net/linux-kernel/2014/07/18/329
Again, please don't commit anything until the syscall number and
interface is finalized. What is out here is for review, and I already
have in the git commit a suggested wrapper to provide getentropy(2).
If you don't think it's good enough, please let me know what your
concerns might be. (And yes, I've fixed the obvious missing open
brace already. :-)
- Ted
next prev parent reply other threads:[~2014-07-18 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 6:49 [PATCH] [RFC] initial getrandom wrapper to provide getentropy for LibreSSL Brent Cook
2014-07-18 13:09 ` Brent Cook
2014-07-18 16:19 ` Theodore Ts'o [this message]
2014-07-18 16:33 ` Brent Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718161936.GA4877@thunk.org \
--to=tytso@mit.edu \
--cc=busterb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.