From: "hch@infradead.org" <hch@infradead.org>
To: KY Srinivasan <kys@microsoft.com>
Cc: James Bottomley <jbottomley@parallels.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"apw@canonical.com" <apw@canonical.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"michaelc@cs.wisc.edu" <michaelc@cs.wisc.edu>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"ohering@suse.com" <ohering@suse.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jasowang@redhat.com" <jasowang@redhat.com>
Subject: Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout
Date: Fri, 18 Jul 2014 10:12:38 -0700 [thread overview]
Message-ID: <20140718171238.GA3159@infradead.org> (raw)
In-Reply-To: <7c46a791325a40fd82572fd3a09726d9@BY2PR0301MB0711.namprd03.prod.outlook.com>
This is what I plan to put in after it passes basic testing:
---
>From bb617c9465b839d70ecbbc69002a20ccf5f935bd Mon Sep 17 00:00:00 2001
From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: Fri, 18 Jul 2014 19:12:58 +0200
Subject: sd: fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O
timeout
Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the
FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use the
basic I/O timeout of the device. Fix this bug.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/scsi/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index bef4e78..9ffb393 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -880,7 +880,7 @@ static int sd_setup_flush_cmnd(struct scsi_cmnd *cmd)
cmd->transfersize = 0;
cmd->allowed = SD_MAX_RETRIES;
- rq->timeout = SD_TIMEOUT * SD_FLUSH_TIMEOUT_MULTIPLIER;
+ rq->timeout = rq->q->rq_timeout * SD_FLUSH_TIMEOUT_MULTIPLIER;
return BLKPREP_OK;
}
--
1.9.1
next prev parent reply other threads:[~2014-07-18 17:12 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 16:33 [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout K. Y. Srinivasan
2014-06-04 16:33 ` K. Y. Srinivasan
2014-06-04 17:02 ` James Bottomley
2014-06-04 17:02 ` James Bottomley
2014-06-04 17:15 ` KY Srinivasan
2014-06-04 17:15 ` KY Srinivasan
2014-06-06 1:32 ` Mike Christie
2014-06-06 2:53 ` KY Srinivasan
2014-06-06 2:53 ` KY Srinivasan
2014-06-06 17:18 ` Mike Christie
2014-06-06 17:18 ` Mike Christie
2014-06-06 17:52 ` James Bottomley
2014-06-06 18:22 ` Jens Axboe
2014-06-20 21:36 ` KY Srinivasan
2014-07-17 23:53 ` KY Srinivasan
2014-07-17 23:53 ` KY Srinivasan
2014-07-18 0:51 ` Elliott, Robert (Server Storage)
2014-07-18 0:51 ` Elliott, Robert (Server Storage)
2014-07-18 15:11 ` Christoph Hellwig (hch@infradead.org)
2014-07-18 15:11 ` Christoph Hellwig (hch@infradead.org)
2014-07-18 15:39 ` James Bottomley
2014-07-18 15:39 ` James Bottomley
2014-07-18 17:17 ` Elliott, Robert (Server Storage)
2014-07-18 17:17 ` Elliott, Robert (Server Storage)
2014-07-18 17:41 ` James Bottomley
2014-07-18 17:41 ` James Bottomley
2014-07-18 18:16 ` Douglas Gilbert
2014-07-18 18:16 ` Douglas Gilbert
2014-07-18 15:10 ` Christoph Hellwig (hch@infradead.org)
2014-07-18 15:10 ` Christoph Hellwig (hch@infradead.org)
2014-07-18 16:44 ` KY Srinivasan
2014-07-18 16:44 ` KY Srinivasan
2014-07-18 16:57 ` James Bottomley
2014-07-18 16:57 ` James Bottomley
2014-07-18 17:01 ` hch
2014-07-18 17:01 ` hch
2014-07-18 17:05 ` KY Srinivasan
2014-07-18 17:05 ` KY Srinivasan
2014-07-18 17:12 ` hch [this message]
2014-07-18 17:15 ` hch
2014-07-18 17:15 ` hch
2014-07-18 17:00 ` Christoph Hellwig
2014-07-18 17:00 ` Christoph Hellwig
2014-07-18 17:03 ` James Bottomley
2014-07-18 17:03 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718171238.GA3159@infradead.org \
--to=hch@infradead.org \
--cc=apw@canonical.com \
--cc=axboe@kernel.dk \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=jbottomley@parallels.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=ohering@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.