All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/opencv: fix dependencies for the Qt and GTK backends
Date: Sun, 20 Jul 2014 10:48:09 +0200	[thread overview]
Message-ID: <20140720104809.09052567@free-electrons.com> (raw)
In-Reply-To: <1405794942-32087-1-git-send-email-yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Sat, 19 Jul 2014 20:35:42 +0200, Yann E. MORIN wrote:

> diff --git a/package/opencv/Config.in b/package/opencv/Config.in
> index 6e938d2..1a026a9 100644
> --- a/package/opencv/Config.in
> +++ b/package/opencv/Config.in
> @@ -159,6 +159,7 @@ config BR2_PACKAGE_OPENCV_WITH_GTK
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk2 -> libglib2
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_USE_MMU # libgtk2 -> glib2
> +	depends on BR2_PACKAGE_OPENCV_LIB_HIGHGUI
>  	select BR2_PACKAGE_LIBGTK2
>  
>  config BR2_PACKAGE_OPENCV_WITH_JASPER
> @@ -188,11 +189,11 @@ config BR2_PACKAGE_OPENCV_WITH_QT
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on !BR2_avr32 # qt
>  	depends on BR2_USE_MMU # qt
> +	depends on BR2_PACKAGE_OPENCV_LIB_HIGHGUI
>  	select BR2_PACKAGE_QT
>  	select BR2_PACKAGE_QT_STL
>  	select BR2_PACKAGE_QT_GUI_MODULE if BR2_PACKAGE_OPENCV_LIB_HIGHGUI
>  	select BR2_PACKAGE_QT_TEST       if BR2_PACKAGE_OPENCV_LIB_HIGHGUI

Can I remove these "if" now that the Qt support anyway depends on
highgui ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-07-20  8:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-19 18:35 [Buildroot] [PATCH] package/opencv: fix dependencies for the Qt and GTK backends Yann E. MORIN
2014-07-20  8:48 ` Thomas Petazzoni [this message]
2014-07-20 14:02   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140720104809.09052567@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.