From: Tony Lindgren <tony@atomide.com>
To: Joel Fernandes <joelf@ti.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] ARM: OMAP2+: timer: Add a powerup function
Date: Mon, 21 Jul 2014 04:00:57 -0700 [thread overview]
Message-ID: <20140721110057.GV18374@atomide.com> (raw)
In-Reply-To: <1398216429-4681-2-git-send-email-joelf@ti.com>
* Joel Fernandes <joelf@ti.com> [140422 18:27]:
> In an effort to isolate the time power initialization for future purposes, add
> a function to do the same. This primarily involves a hwmod lookup, setup and
> enable.
No users yet for this function? Can you remove the same code from
somewhere else in this patch?
Regards,
Tony
> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
> arch/arm/mach-omap2/timer.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index dfb19df..ec427e6 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -210,6 +210,31 @@ static void __init omap_dmtimer_init(void)
> }
> }
>
> +int __init omap_dmtimer_powerup(struct device_node *np)
> +{
> + struct omap_hwmod *oh;
> + const char *oh_name = NULL;
> + int ret;
> +
> + of_property_read_string_index(np, "ti,hwmods", 0, &oh_name);
> + if (!oh_name)
> + return -ENODEV;
> +
> + oh = omap_hwmod_lookup(oh_name);
> + if (!oh)
> + return -ENODEV;
> +
> + ret = omap_hwmod_setup_one(oh_name);
> + if (ret)
> + return ret;
> +
> + ret = omap_hwmod_enable(oh);
> + if (ret)
> + return ret;
> +
> + return 0;
> +}
> +
> /**
> * omap_dm_timer_get_errata - get errata flags for a timer
> *
> --
> 1.7.9.5
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] ARM: OMAP2+: timer: Add a powerup function
Date: Mon, 21 Jul 2014 04:00:57 -0700 [thread overview]
Message-ID: <20140721110057.GV18374@atomide.com> (raw)
In-Reply-To: <1398216429-4681-2-git-send-email-joelf@ti.com>
* Joel Fernandes <joelf@ti.com> [140422 18:27]:
> In an effort to isolate the time power initialization for future purposes, add
> a function to do the same. This primarily involves a hwmod lookup, setup and
> enable.
No users yet for this function? Can you remove the same code from
somewhere else in this patch?
Regards,
Tony
> Signed-off-by: Joel Fernandes <joelf@ti.com>
> ---
> arch/arm/mach-omap2/timer.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index dfb19df..ec427e6 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -210,6 +210,31 @@ static void __init omap_dmtimer_init(void)
> }
> }
>
> +int __init omap_dmtimer_powerup(struct device_node *np)
> +{
> + struct omap_hwmod *oh;
> + const char *oh_name = NULL;
> + int ret;
> +
> + of_property_read_string_index(np, "ti,hwmods", 0, &oh_name);
> + if (!oh_name)
> + return -ENODEV;
> +
> + oh = omap_hwmod_lookup(oh_name);
> + if (!oh)
> + return -ENODEV;
> +
> + ret = omap_hwmod_setup_one(oh_name);
> + if (ret)
> + return ret;
> +
> + ret = omap_hwmod_enable(oh);
> + if (ret)
> + return ret;
> +
> + return 0;
> +}
> +
> /**
> * omap_dm_timer_get_errata - get errata flags for a timer
> *
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2014-07-21 11:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 1:27 [PATCH 0/8] OMAP2+ system timer cleanup series Joel Fernandes
2014-04-23 1:27 ` Joel Fernandes
2014-04-23 1:27 ` [PATCH 1/8] ARM: OMAP2+: timer: Add a powerup function Joel Fernandes
2014-04-23 1:27 ` Joel Fernandes
2014-07-21 11:00 ` Tony Lindgren [this message]
2014-07-21 11:00 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 2/8] ARM: OMAP2+: timer: Simplify clock event/source name setting Joel Fernandes
2014-04-23 1:27 ` Joel Fernandes
2014-07-21 11:05 ` Tony Lindgren
2014-07-21 11:05 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 3/8] ARM: OMAP2+: timer: Add comment on timer clk parenting Joel Fernandes
2014-04-23 1:27 ` Joel Fernandes
2014-07-21 11:07 ` Tony Lindgren
2014-07-21 11:07 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 4/8] ARM: OMAP2+: timer: Remove hwmod look-up dependency for DT-boot Joel Fernandes
2014-04-23 1:27 ` Joel Fernandes
2014-04-23 1:27 ` [PATCH 5/8] ARM: OMAP2+: timer: Use of_clk_get for DT platforms Joel Fernandes
2014-04-23 1:27 ` Joel Fernandes
2014-04-23 1:27 ` [PATCH 6/8] ARM: OMAP2+: timer: Fix error message to not use hwmod structure Joel Fernandes
2014-04-23 1:27 ` Joel Fernandes
2014-07-21 11:09 ` Tony Lindgren
2014-07-21 11:09 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 7/8] ARM: OMAP2+: timer: Add fallback for of_clk_get Joel Fernandes
2014-04-23 1:27 ` Joel Fernandes
2014-07-21 11:10 ` Tony Lindgren
2014-07-21 11:10 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 8/8] ARM: OMAP2+: timer: Add legacy code for old way of getting fclk Joel Fernandes
2014-04-23 1:27 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721110057.GV18374@atomide.com \
--to=tony@atomide.com \
--cc=joelf@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.