From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Aravamudan Date: Mon, 21 Jul 2014 17:42:18 +0000 Subject: Re: [RFC Patch V1 15/30] mm, igb: Use cpu_to_mem()/numa_mem_id() to support memoryless node Message-Id: <20140721174218.GD4156@linux.vnet.ibm.com> List-Id: References: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com> <1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jiang Liu Cc: Andrew Morton , Mel Gorman , David Rientjes , Mike Galbraith , Peter Zijlstra , "Rafael J . Wysocki" , Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Alex Duyck , John Ronciak , Mitch Williams , Linux NICS , Tony Luck , linux-mm@kvack.org, linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org On 11.07.2014 [15:37:32 +0800], Jiang Liu wrote: > When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id() > may return a node without memory, and later cause system failure/panic > when calling kmalloc_node() and friends with returned node id. > So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with > memory for the/current cpu. > > If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id() > is the same as cpu_to_node()/numa_node_id(). > > Signed-off-by: Jiang Liu > --- > drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > index f145adbb55ac..2b74bffa5648 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -6518,7 +6518,7 @@ static bool igb_can_reuse_rx_page(struct igb_rx_buffer *rx_buffer, > unsigned int truesize) > { > /* avoid re-using remote pages */ > - if (unlikely(page_to_nid(page) != numa_node_id())) > + if (unlikely(page_to_nid(page) != numa_mem_id())) > return false; > > #if (PAGE_SIZE < 8192) > @@ -6588,7 +6588,7 @@ static bool igb_add_rx_frag(struct igb_ring *rx_ring, > memcpy(__skb_put(skb, size), va, ALIGN(size, sizeof(long))); > > /* we can reuse buffer as-is, just make sure it is local */ > - if (likely(page_to_nid(page) = numa_node_id())) > + if (likely(page_to_nid(page) = numa_mem_id())) > return true; > > /* this page cannot be reused so discard it */ This doesn't seem to have anything to do with crashes or errors? The original code is checking if the NUMA node of a page is remote to the NUMA node current is running on. Your change makes it check if the NUMA node of a page is not equal to the nearest NUMA node with memory. That's not necessarily local, though, which seems like that is the whole point. In this case, perhaps the driver author doesn't want to reuse the memory at all for performance reasons? In any case, I don't think this patch has appropriate justification. Thanks, Nish From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by kanga.kvack.org (Postfix) with ESMTP id 05E586B0080 for ; Mon, 21 Jul 2014 13:42:27 -0400 (EDT) Received: by mail-vc0-f176.google.com with SMTP id id10so8049671vcb.35 for ; Mon, 21 Jul 2014 10:42:25 -0700 (PDT) Received: from e7.ny.us.ibm.com (e7.ny.us.ibm.com. [32.97.182.137]) by mx.google.com with ESMTPS id n11si27106841qgd.126.2014.07.21.10.42.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Jul 2014 10:42:24 -0700 (PDT) Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 21 Jul 2014 13:42:24 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id CA3CD6E804D for ; Mon, 21 Jul 2014 13:42:12 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp22036.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s6LHgMEK50987074 for ; Mon, 21 Jul 2014 17:42:22 GMT Received: from d01av02.pok.ibm.com (localhost [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s6LHgL7O014410 for ; Mon, 21 Jul 2014 13:42:22 -0400 Date: Mon, 21 Jul 2014 10:42:18 -0700 From: Nishanth Aravamudan Subject: Re: [RFC Patch V1 15/30] mm, igb: Use cpu_to_mem()/numa_mem_id() to support memoryless node Message-ID: <20140721174218.GD4156@linux.vnet.ibm.com> References: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com> <1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu Cc: Andrew Morton , Mel Gorman , David Rientjes , Mike Galbraith , Peter Zijlstra , "Rafael J . Wysocki" , Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Alex Duyck , John Ronciak , Mitch Williams , Linux NICS , Tony Luck , linux-mm@kvack.org, linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org On 11.07.2014 [15:37:32 +0800], Jiang Liu wrote: > When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id() > may return a node without memory, and later cause system failure/panic > when calling kmalloc_node() and friends with returned node id. > So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with > memory for the/current cpu. > > If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id() > is the same as cpu_to_node()/numa_node_id(). > > Signed-off-by: Jiang Liu > --- > drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > index f145adbb55ac..2b74bffa5648 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -6518,7 +6518,7 @@ static bool igb_can_reuse_rx_page(struct igb_rx_buffer *rx_buffer, > unsigned int truesize) > { > /* avoid re-using remote pages */ > - if (unlikely(page_to_nid(page) != numa_node_id())) > + if (unlikely(page_to_nid(page) != numa_mem_id())) > return false; > > #if (PAGE_SIZE < 8192) > @@ -6588,7 +6588,7 @@ static bool igb_add_rx_frag(struct igb_ring *rx_ring, > memcpy(__skb_put(skb, size), va, ALIGN(size, sizeof(long))); > > /* we can reuse buffer as-is, just make sure it is local */ > - if (likely(page_to_nid(page) == numa_node_id())) > + if (likely(page_to_nid(page) == numa_mem_id())) > return true; > > /* this page cannot be reused so discard it */ This doesn't seem to have anything to do with crashes or errors? The original code is checking if the NUMA node of a page is remote to the NUMA node current is running on. Your change makes it check if the NUMA node of a page is not equal to the nearest NUMA node with memory. That's not necessarily local, though, which seems like that is the whole point. In this case, perhaps the driver author doesn't want to reuse the memory at all for performance reasons? In any case, I don't think this patch has appropriate justification. Thanks, Nish -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933398AbaGURme (ORCPT ); Mon, 21 Jul 2014 13:42:34 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:45610 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933142AbaGURm3 (ORCPT ); Mon, 21 Jul 2014 13:42:29 -0400 Date: Mon, 21 Jul 2014 10:42:18 -0700 From: Nishanth Aravamudan To: Jiang Liu Cc: Andrew Morton , Mel Gorman , David Rientjes , Mike Galbraith , Peter Zijlstra , "Rafael J . Wysocki" , Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Alex Duyck , John Ronciak , Mitch Williams , Linux NICS , Tony Luck , linux-mm@kvack.org, linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org Subject: Re: [RFC Patch V1 15/30] mm, igb: Use cpu_to_mem()/numa_mem_id() to support memoryless node Message-ID: <20140721174218.GD4156@linux.vnet.ibm.com> References: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com> <1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com> X-Operating-System: Linux 3.13.0-32-generic (x86_64) User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14072117-0320-0000-0000-0000000A8884 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.07.2014 [15:37:32 +0800], Jiang Liu wrote: > When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id() > may return a node without memory, and later cause system failure/panic > when calling kmalloc_node() and friends with returned node id. > So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with > memory for the/current cpu. > > If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id() > is the same as cpu_to_node()/numa_node_id(). > > Signed-off-by: Jiang Liu > --- > drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > index f145adbb55ac..2b74bffa5648 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -6518,7 +6518,7 @@ static bool igb_can_reuse_rx_page(struct igb_rx_buffer *rx_buffer, > unsigned int truesize) > { > /* avoid re-using remote pages */ > - if (unlikely(page_to_nid(page) != numa_node_id())) > + if (unlikely(page_to_nid(page) != numa_mem_id())) > return false; > > #if (PAGE_SIZE < 8192) > @@ -6588,7 +6588,7 @@ static bool igb_add_rx_frag(struct igb_ring *rx_ring, > memcpy(__skb_put(skb, size), va, ALIGN(size, sizeof(long))); > > /* we can reuse buffer as-is, just make sure it is local */ > - if (likely(page_to_nid(page) == numa_node_id())) > + if (likely(page_to_nid(page) == numa_mem_id())) > return true; > > /* this page cannot be reused so discard it */ This doesn't seem to have anything to do with crashes or errors? The original code is checking if the NUMA node of a page is remote to the NUMA node current is running on. Your change makes it check if the NUMA node of a page is not equal to the nearest NUMA node with memory. That's not necessarily local, though, which seems like that is the whole point. In this case, perhaps the driver author doesn't want to reuse the memory at all for performance reasons? In any case, I don't think this patch has appropriate justification. Thanks, Nish From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Aravamudan Subject: Re: [RFC Patch V1 15/30] mm, igb: Use cpu_to_mem()/numa_mem_id() to support memoryless node Date: Mon, 21 Jul 2014 10:42:18 -0700 Message-ID: <20140721174218.GD4156@linux.vnet.ibm.com> References: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com> <1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Peter Zijlstra , linux-hotplug@vger.kernel.org, linux-mm@kvack.org, Mike Galbraith , e1000-devel@lists.sourceforge.net, "Rafael J . Wysocki" , Jesse Brandeburg , Mel Gorman , David Rientjes , Linux NICS , Tony Luck , netdev@vger.kernel.org, Bruce Allan , linux-kernel@vger.kernel.org, John Ronciak , Andrew Morton To: Jiang Liu Return-path: Content-Disposition: inline In-Reply-To: <1405064267-11678-16-git-send-email-jiang.liu@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On 11.07.2014 [15:37:32 +0800], Jiang Liu wrote: > When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id() > may return a node without memory, and later cause system failure/panic > when calling kmalloc_node() and friends with returned node id. > So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with > memory for the/current cpu. > > If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id() > is the same as cpu_to_node()/numa_node_id(). > > Signed-off-by: Jiang Liu > --- > drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > index f145adbb55ac..2b74bffa5648 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -6518,7 +6518,7 @@ static bool igb_can_reuse_rx_page(struct igb_rx_buffer *rx_buffer, > unsigned int truesize) > { > /* avoid re-using remote pages */ > - if (unlikely(page_to_nid(page) != numa_node_id())) > + if (unlikely(page_to_nid(page) != numa_mem_id())) > return false; > > #if (PAGE_SIZE < 8192) > @@ -6588,7 +6588,7 @@ static bool igb_add_rx_frag(struct igb_ring *rx_ring, > memcpy(__skb_put(skb, size), va, ALIGN(size, sizeof(long))); > > /* we can reuse buffer as-is, just make sure it is local */ > - if (likely(page_to_nid(page) == numa_node_id())) > + if (likely(page_to_nid(page) == numa_mem_id())) > return true; > > /* this page cannot be reused so discard it */ This doesn't seem to have anything to do with crashes or errors? The original code is checking if the NUMA node of a page is remote to the NUMA node current is running on. Your change makes it check if the NUMA node of a page is not equal to the nearest NUMA node with memory. That's not necessarily local, though, which seems like that is the whole point. In this case, perhaps the driver author doesn't want to reuse the memory at all for performance reasons? In any case, I don't think this patch has appropriate justification. Thanks, Nish ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired