From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org,
ac100@lists.launchpad.net
Subject: Re: [PATCH] staging/nvec: Pass proper resource to mfd_add_devices()
Date: Mon, 21 Jul 2014 14:20:13 -0700 [thread overview]
Message-ID: <20140721212013.GA13866@kroah.com> (raw)
In-Reply-To: <1405943561-2656-1-git-send-email-thierry.reding@gmail.com>
On Mon, Jul 21, 2014 at 01:52:41PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The mfd_add_devices() parameter takes a struct resource * as fifth
> argument, but the nvec driver passes in a void __iomem *. The driver
> gets away with it because none of the subdevices ever directly access
> the registers.
>
> While at it, use platform_get_irq() instead of platform_get_resource()
> to get the device's interrupt. This makes it easier to pass in the
> register region since the variable is no longer reused.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Alternatively we could simply pass NULL into mfd_add_devices(), which
> might be a slightly more accurate representation of what's going on.
>
> Marc, Greg, any preferences?
None from me, Marc?
prev parent reply other threads:[~2014-07-21 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 11:52 [PATCH] staging/nvec: Pass proper resource to mfd_add_devices() Thierry Reding
2014-07-21 20:01 ` Marc Dietrich
2014-07-21 21:39 ` Greg Kroah-Hartman
[not found] ` <20140721213915.GA8168-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-07-21 21:49 ` Thierry Reding
2014-07-21 21:20 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721212013.GA13866@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ac100@lists.launchpad.net \
--cc=devel@driverdev.osuosl.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.