From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Herbszt Subject: Re: [PATCH] multipath: revert fstack-protector-strong gcc option Date: Tue, 22 Jul 2014 11:58:05 +0200 Message-ID: <20140722115805.00004b68@localhost> References: <1405984252-26424-1-git-send-email-bmarzins@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1405984252-26424-1-git-send-email-bmarzins@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Benjamin Marzinski Cc: device-mapper development , Sebastian Herbszt , Christophe Varoqui List-Id: dm-devel.ids Benjamin Marzinski wrote: > In my "enable gcc format-security check" (9b7741c) commit, I changed > fstack-protector to fstack-protector-strong. This new option only exists > in gcc 4.9, which is relatively new. This patch reverts to the > fstack-protector option for now, until gcc 4.9 has been around for longer. > > Signed-off-by: Benjamin Marzinski > --- > Makefile.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.inc b/Makefile.inc > index 1486721..20ae23e 100644 > --- a/Makefile.inc > +++ b/Makefile.inc > @@ -46,7 +46,7 @@ GZIP = gzip -9 -c > INSTALL_PROGRAM = install > > ifndef RPM_OPT_FLAGS > - RPM_OPT_FLAGS = -O2 -g -pipe -Wformat-security -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 > + RPM_OPT_FLAGS = -O2 -g -pipe -Wformat-security -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 > endif > > OPTFLAGS = $(RPM_OPT_FLAGS) -Wunused -Wstrict-prototypes Tested-by: Sebastian Herbszt