From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fabio Falzoi <fabio.falzoi84@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
joe@perches.com
Subject: Re: [PATCH v4 1/3] Staging: rts5208: Replace custom macro with dev_dbg
Date: Tue, 22 Jul 2014 15:58:20 +0300 [thread overview]
Message-ID: <20140722125820.GO25880@mwanda> (raw)
In-Reply-To: <1405978564-11343-2-git-send-email-fabio.falzoi84@gmail.com>
On Mon, Jul 21, 2014 at 11:36:02PM +0200, Fabio Falzoi wrote:
> @@ -3664,7 +3672,7 @@ static int mg_set_tpc_para_sub(struct rtsx_chip *chip, int type,
> int retval;
> u8 buf[6];
>
> - RTSX_DEBUGP("--%s--\n", __func__);
> + dev_dbg(rtsx_dev(chip), "--%s--\n", __func__);
All of these debug printks to mark when we have called a function should
be deleted. We have ftrace for that.
> -static inline void free_zone(struct zone_entry *zone)
> +static inline void free_zone(const struct rtsx_chip *chip,
> + struct zone_entry *zone)
> {
> - RTSX_DEBUGP("free_zone\n");
> + dev_dbg(rtsx_dev(chip), "free_zone\n");
>
> if (!zone)
> return;
Don't add a parameter to free_zone() just for this debug printk which
should be deleted.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-22 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 21:36 [PATCH v4 0/3] Staging: rts5208: Use standard debug features Fabio Falzoi
2014-07-21 21:36 ` [PATCH v4 1/3] Staging: rts5208: Replace custom macro with dev_dbg Fabio Falzoi
2014-07-22 12:58 ` Dan Carpenter [this message]
2014-07-21 21:36 ` [PATCH v4 2/3] Staging: rts5208: Use dev_dbg and %*ph specifier to dump memory Fabio Falzoi
2014-07-21 21:36 ` [PATCH v4 3/3] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option Fabio Falzoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722125820.GO25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.