Re: [PATCH 03/24] debugfs: create idump command to dump an inode in hex

[Theodore Ts'o <tytso@mit.edu>]

On Fri, Jul 18, 2014 at 03:52:36PM -0700, Darrick J. Wong wrote:
> Create a command that will dump an entire inode's space in hex.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Applied with the following addition which (a) adds a formal longer
command name ("inode_dump") to be analogous with the "block_dump"
command, and (b) adds an entry to the debugfs man page.

	     	      	       	  - Ted

diff --git a/debugfs/debug_cmds.ct b/debugfs/debug_cmds.ct
index ef4c5c4..ed3728f 100644
--- a/debugfs/debug_cmds.ct
+++ b/debugfs/debug_cmds.ct
@@ -188,7 +188,7 @@ request do_zap_block, "Zap block: fill with 0, pattern, flip bits etc.",
 	zap_block, zap;
 
 request do_block_dump, "Dump contents of a block",
-	block_dump, bd;
+	block_dump, bdump, bd;
 
 request do_list_quota, "List quota",
 	list_quota, lq;
@@ -196,8 +196,8 @@ request do_list_quota, "List quota",
 request do_get_quota, "Get quota",
 	get_quota, gq;
 
-request do_idump, "Dump inode",
-	idump;
+request do_idump, "Dump the inode structure in hex",
+	inode_dump, idump, id;
 
 
 end;
diff --git a/debugfs/debugfs.8.in b/debugfs/debugfs.8.in
index 73254d3..9a125f6 100644
--- a/debugfs/debugfs.8.in
+++ b/debugfs/debugfs.8.in
@@ -346,6 +346,9 @@ showing its tree structure.
 Print a listing of the inodes which use the one or more blocks specified
 on the command line.
 .TP
+.BI inode_dump " filespec"
+Print the contents of the inode data structure in hex and ASCII format.
+.TP
 .BI imap " filespec"
 Print the location of the inode data structure (in the inode table)
 of the inode