Re: [PATCH] command/runqueue: Fix shutdown logic

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3169 bytes --]

On Tue, Jul 22, 2014 at 07:10:31PM +0100, Richard Purdie wrote:
> On Tue, 2014-07-22 at 16:46 +0200, Martin Jansa wrote:
> > On Mon, Jul 21, 2014 at 09:35:53AM +0100, Richard Purdie wrote:
> > > If you hit Ctrl+C at the right point, the system processes the request
> > > but merrily continues building. It turns out finish_runqueue() is called
> > > but this doesn't stop the later generation and execution of the
> > > runqueue.
> > > 
> > > This patch adjusts some of the conditionals to ensure the build really
> > > does stop.
> > 
> > Great, I've included this change in my world builds to see if it fixes
> > bitbake still running after jenkins job is aborted.
> 
> I've seen that too and I don't think this fix will address that
> unfortunately. Its on my list of things to look into.
> 
> > I don't think it's caused by this change and I don't know how much we
> > can do about it, but today I was testing snort build (which eats all
> > memory in m4 call until OOMK kills it) 
> 
> I ended up excluding snort from my builds for that reason. Builds go a
> lot faster when its not destroying the machine!

adding pkgconfig inherit fixed that, but indeed strange side effect

and it seems to trigger this memory eating only in combination with more
restrictive m4 dependencies or foreign flag (but I got OOM even after
patching snort's configure.in to pass foreign).

> > and when I wanted to interrupt
> > the build it failed with 2 tracebacks:
> > 
> > NOTE: Preparing runqueue
> > NOTE: Executing SetScene Tasks
> > NOTE: Executing RunQueue Tasks
> > NOTE: Running task 569 of 610 (ID: 5, /OE/build/oe-core/meta-openembedded/meta-networking/recipes-connectivity/snort/snort_2.9.6.0.bb, do_configure)
> > NOTE: recipe snort-2.9.6.0-r0: task do_configure: Started
> > ^C^C^C^C^C^C^C^C^C^C^C^C^C^CTraceback (most recent call last):
> >   File "/OE/build/oe-core/bitbake/bin/bitbake", line 382, in <module>
> >     ret = main()
> >   File "/OE/build/oe-core/bitbake/bin/bitbake", line 372, in main
> >     bb.event.ui_queue = []
> > KeyboardInterrupt
> > ^CException KeyboardInterrupt in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored
> > 
> > ^CError in atexit._run_exitfuncs:
> > ^CError in sys.exitfunc:
> > Traceback (most recent call last):
> >   File "/usr/lib64/python2.7/atexit.py", line 30, in _run_exitfuncs
> >     traceback.print_exc()
> >   File "/usr/lib64/python2.7/traceback.py", line 233, in print_exc
> >     print_exception(etype, value, tb, limit, file)
> >   File "/usr/lib64/python2.7/traceback.py", line 110, in print_exception
> >     def print_exception(etype, value, tb, limit=None, file=None):
> > KeyboardInterrupt
> > 
> > There was also about 5 minute delay between first 2 Ctrl+C and actual
> > exit, but that could be caused by huge load caused by that faulty m4.
> 
> Thanks, I'll have a look at those and see if they're significant and if
> we can do anything about them. It may be they are "one offs" and
> unlikely to reproduce but we'll see.
> 
> Cheers,
> 
> Richard
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]