All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Vladimir Davydov <vdavydov@parallels.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>
Subject: [mmotm:master 155/499] mm/memcontrol.c:2946 memcg_update_cache_size() error: we previously assumed 'cur_params' could be null (see line 2932)
Date: Wed, 23 Jul 2014 11:02:25 +0300	[thread overview]
Message-ID: <20140723080225.GG13737@mwanda> (raw)

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   bb46fa8ad844d29e9f74f6209777d955a42916f6
commit: dbc3484b1953f019f408b7c1ecaa3f5e0e8c24bb [155/499] memcg: keep all children of each root cache on a list

mm/memcontrol.c:2946 memcg_update_cache_size() error: we previously assumed 'cur_params' could be null (see line 2932)

git remote add mmotm git://git.cmpxchg.org/linux-mmotm.git
git remote update mmotm
git checkout dbc3484b1953f019f408b7c1ecaa3f5e0e8c24bb
vim +/cur_params +2946 mm/memcontrol.c

f8570263 Vladimir Davydov 2014-01-23  2926  		new_params = kzalloc(size, GFP_KERNEL);
f8570263 Vladimir Davydov 2014-01-23  2927  		if (!new_params)
55007d84 Glauber Costa    2012-12-18  2928  			return -ENOMEM;
55007d84 Glauber Costa    2012-12-18  2929  
f8570263 Vladimir Davydov 2014-01-23  2930  		new_params->is_root_cache = true;
dbc3484b Vladimir Davydov 2014-07-22  2931  		INIT_LIST_HEAD(&new_params->children);
dbc3484b Vladimir Davydov 2014-07-22 @2932  		if (cur_params)
dbc3484b Vladimir Davydov 2014-07-22  2933  			list_replace(&cur_params->children,
dbc3484b Vladimir Davydov 2014-07-22  2934  				     &new_params->children);
55007d84 Glauber Costa    2012-12-18  2935  
55007d84 Glauber Costa    2012-12-18  2936  		/*
55007d84 Glauber Costa    2012-12-18  2937  		 * There is the chance it will be bigger than
55007d84 Glauber Costa    2012-12-18  2938  		 * memcg_limited_groups_array_size, if we failed an allocation
55007d84 Glauber Costa    2012-12-18  2939  		 * in a cache, in which case all caches updated before it, will
55007d84 Glauber Costa    2012-12-18  2940  		 * have a bigger array.
55007d84 Glauber Costa    2012-12-18  2941  		 *
55007d84 Glauber Costa    2012-12-18  2942  		 * But if that is the case, the data after
55007d84 Glauber Costa    2012-12-18  2943  		 * memcg_limited_groups_array_size is certainly unused
55007d84 Glauber Costa    2012-12-18  2944  		 */
55007d84 Glauber Costa    2012-12-18  2945  		for (i = 0; i < memcg_limited_groups_array_size; i++) {
55007d84 Glauber Costa    2012-12-18 @2946  			if (!cur_params->memcg_caches[i])
55007d84 Glauber Costa    2012-12-18  2947  				continue;
f8570263 Vladimir Davydov 2014-01-23  2948  			new_params->memcg_caches[i] =
55007d84 Glauber Costa    2012-12-18  2949  						cur_params->memcg_caches[i];

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

                 reply	other threads:[~2014-07-23  8:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140723080225.GG13737@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild@01.org \
    --cc=linux-mm@kvack.org \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.