From: Rob Kendrick <rob.kendrick@codethink.co.uk>
To: Markos Chandras <Markos.Chandras@imgtec.com>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: EdgeRouter Pro supported? Strange FP problems
Date: Wed, 23 Jul 2014 10:03:58 +0100 [thread overview]
Message-ID: <20140723090357.GN30723@humdrum> (raw)
In-Reply-To: <53CE8570.8020404@imgtec.com>
On Tue, Jul 22, 2014 at 04:38:24PM +0100, Markos Chandras wrote:
> a quick bisect between v3.15 and v3.16-rc1, which is the first tag with
> all the new FPU changes, leads to the following bad commit:
>
> 08a07904e182895e1205f399465a3d622c0115b8
> MIPS: math-emu: Remove most ifdefery.
This appears to fix the problem:
diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c
index 736c17a..bf0fc6b 100644
--- a/arch/mips/math-emu/cp1emu.c
+++ b/arch/mips/math-emu/cp1emu.c
@@ -1827,7 +1827,7 @@ dcopuop:
case -1:
if (cpu_has_mips_4_5_r)
- cbit = fpucondbit[MIPSInst_RT(ir) >> 2];
+ cbit = fpucondbit[MIPSInst_FD(ir) >> 2];
else
cbit = FPU_CSR_COND;
if (rv.w)
Sadly I am totally ignorant of kernel patch processes. What would be
approach to having this properly submitted?
--
Rob Kendrick, Senior Consulting Developer Codethink Ltd.
Telephone: +44 7880 657 193 302 Ducie House, Ducie Street,
http://www.codethink.co.uk/ Manchester, M1 2JW, United Kingdom.
next prev parent reply other threads:[~2014-07-23 9:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 13:06 EdgeRouter Pro supported? Strange FP problems Rob Kendrick
2014-07-22 14:21 ` Markos Chandras
2014-07-22 14:21 ` Markos Chandras
2014-07-22 14:33 ` Rob Kendrick
2014-07-22 15:38 ` Markos Chandras
2014-07-22 15:38 ` Markos Chandras
2014-07-22 15:49 ` Rob Kendrick
2014-07-22 18:41 ` Aaro Koskinen
2014-07-23 9:03 ` Rob Kendrick [this message]
2014-07-23 9:06 ` Markos Chandras
2014-07-23 9:06 ` Markos Chandras
2014-07-22 15:26 ` John Crispin
2014-07-23 7:03 ` Rob Kendrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723090357.GN30723@humdrum \
--to=rob.kendrick@codethink.co.uk \
--cc=Markos.Chandras@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.