All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [patch] checkpatch: warn on missing spaces in broken up quoted strings
Date: Wed, 23 Jul 2014 14:56:47 +0300	[thread overview]
Message-ID: <20140723115647.GQ13737@mwanda> (raw)
In-Reply-To: <1402943256.3182.2.camel@joe-AO725>

On Mon, Jun 16, 2014 at 11:27:36AM -0700, Joe Perches wrote:
> > > Likely the \\[a-zA-Z] check should include
> > > all the tests that the multiple line string exceptions use.
> > > 
> > > (?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$
> > 
> > That kind of complicate regex hurts my head.  How do I make it not
> > complain about:
> > 		"foo\n\t"
> > 		"bar";
> 
> Did you try it?
> 

Of course I tried it...  I certainly am not able to *read* it.  :P
I think that I don't know what you meant?  Just give me a whole patch I
can apply.

I also tested my version against patches and not just whole files and it
seems to work fine.

regards,
dan carpenter


  reply	other threads:[~2014-07-23 11:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13  6:53 [patch] checkpatch: warn on missing spaces in broken up quoted strings Dan Carpenter
2014-06-13  9:30 ` Joe Perches
2014-06-13  9:46   ` Dan Carpenter
2014-06-13 19:52     ` Joe Perches
2014-06-16  6:40       ` Dan Carpenter
2014-06-16 18:27         ` Joe Perches
2014-07-23 11:56           ` Dan Carpenter [this message]
2014-07-23 12:11           ` [patch v2] checkpatch: warn on missing spaces in broken up quoted Dan Carpenter
2014-07-23 12:11             ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140723115647.GQ13737@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.