All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cliff Wickman <cpw@sgi.com>
To: Filipe Brandenburger <filbranden@google.com>
Cc: linux-numa@vger.kernel.org, Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH] build-sys: prevent warning about .depend when running make
Date: Wed, 23 Jul 2014 07:26:19 -0500	[thread overview]
Message-ID: <20140723122619.GA23761@sgi.com> (raw)
In-Reply-To: <1406065795-30520-1-git-send-email-filbranden@google.com>

Hi Filipe,

Applied.  (numactl-2.0.10-rc2)

Thanks.

-Cliff

On Tue, Jul 22, 2014 at 02:49:55PM -0700, Filipe Brandenburger wrote:
> This is the typical warning:
>   $ make clean >/dev/null
>   Makefile:200: .depend: No such file or directory
> 
> It happens because there is no rule to build .depend before executing
> the make action.
> 
> Ignoring errors when including generated dependency information seems to
> be the norm in Makefiles, so we might as well do it here.
> 
> Tested:
> - Checked that the warning is gone with the patch:
>   $ make clean >/dev/null
>   (empty)
> - Built libnuma and ran make test_numademo, confirmed it works.
> 
> Signed-off-by: Filipe Brandenburger <filbranden@google.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index fe42638fbca4..53191af58f8f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -197,7 +197,7 @@ depend: .depend
>  .depend:
>  	${CC} -MM -DDEPS_RUN -I. ${SOURCES} > .depend.X && mv .depend.X .depend
>  
> -include .depend
> +-include .depend
>  
>  Makefile: .depend
>  
> -- 
> 2.0.0.526.g5318336

-- 
Cliff Wickman
SGI
cpw@sgi.com
(651) 683-3824
(651) 482-9347h

      reply	other threads:[~2014-07-23 12:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 21:49 [PATCH] build-sys: prevent warning about .depend when running make Filipe Brandenburger
2014-07-23 12:26 ` Cliff Wickman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140723122619.GA23761@sgi.com \
    --to=cpw@sgi.com \
    --cc=filbranden@google.com \
    --cc=gthelen@google.com \
    --cc=linux-numa@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.