From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] ftrace: kill the dead code in trace_sched_switch.c
Date: Wed, 23 Jul 2014 21:34:44 +0200 [thread overview]
Message-ID: <20140723193444.GA30194@redhat.com> (raw)
On 07/23, Oleg Nesterov wrote:
>
> This motivated me to try to find something else unused. And it seems that
> almost all code in kernel/trace/trace_sched_switch.c is dead? Hmm, and
> probably even event_context_switch... I'll recheck and send the patch.
No, event_context_switch can't simply go away. But afaics the only user
is tracing_sched_switch_trace(), and the only caller of this function is
probe_wakeup_sched_switch(). Looks a bit strange.
After this patch we should probably move tracing_sched_switch_trace() and
tracing_sched_wakeup_trace() from trace_sched_switch.c to trace_sched_wakeup.c
and make them static. And perhaps we can also move the rest of this
code somewhere else and rm this file...
Oleg.
kernel/trace/trace.h | 3 -
kernel/trace/trace_sched_switch.c | 88 -------------------------------------
2 files changed, 0 insertions(+), 91 deletions(-)
next reply other threads:[~2014-07-23 19:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 19:34 Oleg Nesterov [this message]
2014-07-23 19:35 ` [PATCH 1/2] ftrace: Kill tracing_{start,stop}_sched_switch_record() and tracing_sched_switch_assign_trace() Oleg Nesterov
2014-07-23 19:35 ` [PATCH 2/2] ftrace: Kill the dead code in probe_sched_switch() and probe_sched_wakeup() Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723193444.GA30194@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.