From: "Theodore Ts'o" <tytso@mit.edu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
acab@digitalfuture.it, stable@kernel.org
Subject: Re: [PATCH] random: fix 32MB+ reads from /dev/urandom
Date: Wed, 23 Jul 2014 16:26:41 -0400 [thread overview]
Message-ID: <20140723202641.GF6673@thunk.org> (raw)
In-Reply-To: <20140723171421.GA2997@p183.telecom.by>
I don't think this patch is worthwhile. There is no legitimate reason
to be using such large reads like this, and read(2) is always allowed
to return a short read (for example, if a signal comes in while the
read is happening). The only difference is that we are now guaranteed
to return a short-read if you try to read more than 32MB. Given that
there is no valid reason to ask for more than 256 or maybe 512 bytes
at a time, I'm not particularly worried about this.
If you really care, you can ask dd keep reading after a short read by
using "iflag=fullblock".
- Ted
next prev parent reply other threads:[~2014-07-23 20:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 17:14 [PATCH] random: fix 32MB+ reads from /dev/urandom Alexey Dobriyan
2014-07-23 20:26 ` Theodore Ts'o [this message]
2014-08-09 7:48 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723202641.GF6673@thunk.org \
--to=tytso@mit.edu \
--cc=acab@digitalfuture.it \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.