From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: include C libraries in legal-info
Date: Thu, 24 Jul 2014 00:13:50 +0200 [thread overview]
Message-ID: <20140723221350.GD17249@free.fr> (raw)
In-Reply-To: <1406153080-29619-1-git-send-email-yann.morin.1998@free.fr>
All,
On 2014-07-24 00:04 +0200, Yann E. MORIN spake thusly:
> So far, the legal-info infrastructure was not exporting the legal
> info for the C libraries. This is because the legal-info only acts
> on packages defined in $(TARGETS).
>
> But the C libraries are never added to $(TARGETS), since there is no
> corresponding BR2_PACKAGE_<C-LIBRARY>.
>
> This patch adds such symbols for the 4 C libraries we support in our
> internal backend: uClibc, glibc, eglibc and musl.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
>
> ---
> Tested by building the toolchain of the defconfig, which is
> uClibc-based. Tests not replicated to other C libraries.
> ---
> Makefile | 4 ++++
> package/glibc/Config.in | 10 ++++++++++
> package/musl/Config.in | 4 ++++
> package/uclibc/Config.in | 5 +++++
> 4 files changed, 23 insertions(+)
> create mode 100644 package/musl/Config.in
>
> diff --git a/Makefile b/Makefile
> index 1af51de..17a11f7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -419,6 +419,10 @@ dirs: $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
> $(BUILD_DIR)/buildroot-config/auto.conf: $(BR2_CONFIG)
> $(MAKE1) $(EXTRAMAKEARGS) HOSTCC="$(HOSTCC_NOCCACHE)" HOSTCXX="$(HOSTCXX_NOCCACHE)" silentoldconfig
>
> +.PHONY: DEBUG-ME
> +DEBUG-ME:
> + @echo $(TARGETS)
> +
As Thomas astutely noticed, this should probably not be here... :-)
I will respin later, waiting for more reviews...
Regards,
Yann E. MORIN.
> prepare: $(BUILD_DIR)/buildroot-config/auto.conf
>
> world: target-post-image
> diff --git a/package/glibc/Config.in b/package/glibc/Config.in
> index c2d6231..df1e273 100644
> --- a/package/glibc/Config.in
> +++ b/package/glibc/Config.in
> @@ -1,5 +1,10 @@
> if BR2_TOOLCHAIN_BUILDROOT_EGLIBC
>
> +# For legal-info
> +config BR2_PACKAGE_EGLIBC
> + bool
> + default y
> +
> choice
> prompt "eglibc version"
> default BR2_EGLIBC_VERSION_2_18
> @@ -18,6 +23,11 @@ endif
>
> if BR2_TOOLCHAIN_BUILDROOT_GLIBC
>
> +# For legal-info
> +config BR2_PACKAGE_GLIBC
> + bool
> + default y
> +
> choice
> prompt "glibc version"
> default BR2_GLIBC_VERSION_2_18
> diff --git a/package/musl/Config.in b/package/musl/Config.in
> new file mode 100644
> index 0000000..f5c1b57
> --- /dev/null
> +++ b/package/musl/Config.in
> @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_MUSL
> + bool
> + depends on BR2_TOOLCHAIN_USES_MUSL
> + default y
> diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
> index 0838b6c..851ad1e 100644
> --- a/package/uclibc/Config.in
> +++ b/package/uclibc/Config.in
> @@ -1,5 +1,10 @@
> if BR2_TOOLCHAIN_BUILDROOT_UCLIBC
>
> +# For legal-info
> +config BR2_PACKAGE_UCLIBC
> + bool
> + default y
> +
> comment "uClibc Options"
>
> choice
> --
> 1.9.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2014-07-23 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 22:04 [Buildroot] [PATCH] toolchain: include C libraries in legal-info Yann E. MORIN
2014-07-23 22:13 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723221350.GD17249@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.