From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Patrick McHardy <kaber@trash.net>,
netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH nf-next] netfilter: xt_hashlimit: perform garbage collection from process context
Date: Thu, 24 Jul 2014 13:08:04 +0200 [thread overview]
Message-ID: <20140724110804.GA15610@salvia> (raw)
In-Reply-To: <20140724082744.GA18404@breakpoint.cc>
On Thu, Jul 24, 2014 at 10:27:44AM +0200, Florian Westphal wrote:
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
> > xt_hashlimit cannot be used with large hash tables, because garbage
> > collector is run from a timer. If table is really big, its possible
> > to hold cpu for more than 500 msec, which is unacceptable.
> >
> > Switch to a work queue, and use proper scheduling points to remove
> > latencies spikes.
> >
> > Later, we also could switch to a smoother garbage collection done
> > at lookup time, one bucket at a time...
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Reviewed-by: Florian Westphal <fw@strlen.de>
Applied, thanks Eric!
prev parent reply other threads:[~2014-07-24 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 4:36 [PATCH nf-next] netfilter: xt_hashlimit: perform garbage collection from process context Eric Dumazet
2014-07-24 8:27 ` Florian Westphal
2014-07-24 11:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724110804.GA15610@salvia \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.