From: Florian Westphal <fw@strlen.de>
To: Patrick McHardy <kaber@trash.net>
Cc: Florian Westphal <fw@strlen.de>, Josh Hunt <johunt@akamai.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
Harald Welte <laforge@netfilter.org>,
Jan Engelhardt <jengelh@medozas.de>
Subject: Re: [PATCH] netfilter: xt_hashlimit: handle iptables-restore of hash with same name
Date: Thu, 24 Jul 2014 13:48:46 +0200 [thread overview]
Message-ID: <20140724114846.GE18404@breakpoint.cc> (raw)
In-Reply-To: <ffaf5ee3-2af6-4747-bdd1-481ed87e68aa@email.android.com>
Patrick McHardy <kaber@trash.net> wrote:
> On 24. Juli 2014 09:49:27 GMT+01:00, Florian Westphal <fw@strlen.de> wrote:
> >Josh Hunt <johunt@akamai.com> wrote:
> >> Currently when we do do this the new parameters are not enforced.
> >
> >Note that:
> >
> >-A INPUT -m hashlimit --hashlimit-upto 10/sec --hashlimit-burst 10
> >--hashlimit-name test
> >-A INPUT -m hashlimit --hashlimit-upto 1/sec --hashlimit-burst 10
> >--hashlimit-name test
> >
> >doesn't work as expected either (rule #2 uses config options of #1).
> >
> >I think is behaviour is so unexpected that I would consider this a
> >bug...
>
> True, but it's a bug that has existed forever and I've seen scripts that actually rely on this.
Too bad. In that case it seems like we really cannot fix this 8-(
next prev parent reply other threads:[~2014-07-24 11:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 4:54 [PATCH] netfilter: xt_hashlimit: handle iptables-restore of hash with same name Josh Hunt
2014-07-22 20:49 ` Josh Hunt
2014-07-24 8:49 ` Florian Westphal
2014-07-24 10:53 ` Patrick McHardy
2014-07-24 11:48 ` Florian Westphal [this message]
2014-07-25 16:57 ` Josh Hunt
2014-08-14 14:09 ` Holger Eitzenberger
2014-08-15 3:58 ` Jan Engelhardt
2014-08-15 7:24 ` Holger Eitzenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724114846.GE18404@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=jengelh@medozas.de \
--cc=johunt@akamai.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.