From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 0/2] pinctrl: sunxi: misc improvements for gpio Date: Thu, 24 Jul 2014 14:57:50 +0200 Message-ID: <20140724125750.GY20328@lukather> References: <1405358677-23657-1-git-send-email-wens@csie.org> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1olvqv+k0f6DP9aD" Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Linus Walleij Cc: Chen-Yu Tsai , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi List-Id: linux-gpio@vger.kernel.org --1olvqv+k0f6DP9aD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 22, 2014 at 06:33:10PM +0200, Linus Walleij wrote: > > AFAIK pinctrl pin numbers are device specific, so I'm wondering if we > > should also number them in terms of offsets, rather than absolute pin > > numbers. It's more of an asthetic change though. Any thoughts? >=20 > Usually I say these pin numbers should try to match what is > in the data sheet so it is easy to understand and debug. Sometimes > pins are numbered with letters and stuff so they rather have names > than numbers, then some artificial numbering is applied, whatever > is helpful. >=20 > I'm not directly familiar with the sunxi numbering system though... I'd prefer if we had an absolute number that more or less matches the one in the datasheet. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --1olvqv+k0f6DP9aD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT0QLOAAoJEBx+YmzsjxAgmbUQALojCNA5aPjdnTT6wiRt180S dUOIeXrI1dNI93G6QteHB0el/6qq4wH3XFZuGdVhDZPhk8KictBo/4yRZxhNiwSm jrWtiW7zuCPDV8sBNxvmNlDGPg2T0Z0NsE1AwU/BmQcwqCYkhR3b2cilo9hmI3+2 VvmvVpwoFog1W8BMGqx0Y3yTfIFlwa/syNnBwFmf5IliOztp6GCEdNIaknFaY2RE SpP2YMATfodHnMj3znmok2kvUiQ/BHIATxdj9yQkisjr2OTiMy1IP02miFvotMZZ dykVMT9ENI4NSv169NvGgxmhxYaxg3aj6SJgHn+/gVwh9oGiBKJM3hnS79I8c1hu aHnntgxRykNhWYE6umwsnWIIISY5TD/pr8HaLerwQjoirpm491KyPQmZ0ZZYs7BH NcPUFXg8cnK3zV3qFR8CgSOlrOsyV1gN034Ty6p19JowaSuDs+g7wTWncE6FoQSw NI1dUVOlgn7547/hStilHbsbM3Aok2vG1Eo/TFyyCDKVdCyq4aBCMpo2NKkhBNOq LbZj+lmDjVOLa9oi1G9iNxh0jO/xSSQc0Cy6OsT0bazggvXjh0l3pVxRMymLt5yj sDJ8gOaswshn5VMMalAUfkfuxfTAHenCDRG/rOpHyxjDYZgUJwvW05ktnYUpf0Sa iwgUtja7mBjyJudVzPAr =rzrA -----END PGP SIGNATURE----- --1olvqv+k0f6DP9aD-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Thu, 24 Jul 2014 14:57:50 +0200 Subject: [PATCH 0/2] pinctrl: sunxi: misc improvements for gpio In-Reply-To: References: <1405358677-23657-1-git-send-email-wens@csie.org> Message-ID: <20140724125750.GY20328@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 22, 2014 at 06:33:10PM +0200, Linus Walleij wrote: > > AFAIK pinctrl pin numbers are device specific, so I'm wondering if we > > should also number them in terms of offsets, rather than absolute pin > > numbers. It's more of an asthetic change though. Any thoughts? > > Usually I say these pin numbers should try to match what is > in the data sheet so it is easy to understand and debug. Sometimes > pins are numbered with letters and stuff so they rather have names > than numbers, then some artificial numbering is applied, whatever > is helpful. > > I'm not directly familiar with the sunxi numbering system though... I'd prefer if we had an absolute number that more or less matches the one in the datasheet. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: