From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irq: Warn when shared interrupts do not match on NO_SUSPEND
Date: Thu, 24 Jul 2014 16:15:25 +0200 [thread overview]
Message-ID: <20140724141525.GK3935@laptop> (raw)
In-Reply-To: <alpine.DEB.2.10.1407241544500.23352@nanos>
On Thu, Jul 24, 2014 at 03:46:38PM +0200, Thomas Gleixner wrote:
> On Thu, 24 Jul 2014, Peter Zijlstra wrote:
>
> > Subject: irq: Warn when shared interrupts do not match on NO_SUSPEND
> >
> > When suspend_device_irqs() iterates all descriptors, its pointless if
> > one has NO_SUSPEND set while another has not.
> >
> > Validate on request_irq() that NO_SUSPEND state maches for SHARED
> > interrupts.
>
> I'm happy to take that patch, but you are aware that it is going to
> break a few things?
>
> 25: .... PCI-MSI-edge aerdrv, PCIe PME
Better an obvious splat than non obvious misbehaviour in my book.
next prev parent reply other threads:[~2014-07-24 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 13:39 [PATCH] irq: Warn when shared interrupts do not match on NO_SUSPEND Peter Zijlstra
2014-07-24 13:46 ` Thomas Gleixner
2014-07-24 14:15 ` Peter Zijlstra [this message]
2014-07-24 14:39 ` Rafael J. Wysocki
2014-07-24 15:36 ` [tip:irq/core] " tip-bot for Peter Zijlstra
2014-07-31 2:22 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724141525.GK3935@laptop \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.