From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Thu, 24 Jul 2014 16:29:18 +0200 Subject: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS In-Reply-To: <20140724140757.GW23220@titan.lakedaemon.net> References: <1406154923-13612-2-git-send-email-yahoo@perenite.com> <20140723224236.GC28485@lunn.ch> <94F87063-D717-435B-B7C5-EDAC9B26742C@perenite.com> <20140723225841.GD28485@lunn.ch> <10A7C530-7CD2-4ED0-889A-7FAC1922320F@perenite.com> <20140723231535.GK23220@titan.lakedaemon.net> <53D0FA2F.6050209@free-electrons.com> <20140724124520.GV23220@titan.lakedaemon.net> <20140724140757.GW23220@titan.lakedaemon.net> Message-ID: <20140724142918.GG28485@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > The only outstanding point (Arnd?), is that I think it's ok to have the > i2c...a0 compatible string in the dts files, but Andrew seems to think > otherwise. Is that still true Andrew? Hi Jason I can live with i2c...a0 compatible string, but it has minor problems: 1) The binding Documentation says not to do it. So we are ignoring our own documentation. 2) It seems likely that at some point the OEM will swap to B1 revision SoCs. The i2c device then does not require this quirk, but we have hard coded in the DT file that it is required. B1 revision would work, but not optimally. So i would prefer not to explicitly enable the quirk, but determine at run time if the quirk is needed for the SoC revision it is running on. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Date: Thu, 24 Jul 2014 16:29:18 +0200 Message-ID: <20140724142918.GG28485@lunn.ch> References: <1406154923-13612-2-git-send-email-yahoo@perenite.com> <20140723224236.GC28485@lunn.ch> <94F87063-D717-435B-B7C5-EDAC9B26742C@perenite.com> <20140723225841.GD28485@lunn.ch> <10A7C530-7CD2-4ED0-889A-7FAC1922320F@perenite.com> <20140723231535.GK23220@titan.lakedaemon.net> <53D0FA2F.6050209@free-electrons.com> <20140724124520.GV23220@titan.lakedaemon.net> <20140724140757.GW23220@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140724140757.GW23220-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Cooper Cc: Benoit Masson , Andrew Lunn , Arnd Bergmann , Gregory CLEMENT , Benoit Masson , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org > The only outstanding point (Arnd?), is that I think it's ok to have the > i2c...a0 compatible string in the dts files, but Andrew seems to think > otherwise. Is that still true Andrew? Hi Jason I can live with i2c...a0 compatible string, but it has minor problems: 1) The binding Documentation says not to do it. So we are ignoring our own documentation. 2) It seems likely that at some point the OEM will swap to B1 revision SoCs. The i2c device then does not require this quirk, but we have hard coded in the DT file that it is required. B1 revision would work, but not optimally. So i would prefer not to explicitly enable the quirk, but determine at run time if the quirk is needed for the SoC revision it is running on. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759157AbaGXOez (ORCPT ); Thu, 24 Jul 2014 10:34:55 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:52532 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758972AbaGXOey (ORCPT ); Thu, 24 Jul 2014 10:34:54 -0400 Date: Thu, 24 Jul 2014 16:29:18 +0200 From: Andrew Lunn To: Jason Cooper Cc: Benoit Masson , Andrew Lunn , Arnd Bergmann , Gregory CLEMENT , Benoit Masson , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sebastian Hesselbarth Subject: Re: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Message-ID: <20140724142918.GG28485@lunn.ch> References: <1406154923-13612-2-git-send-email-yahoo@perenite.com> <20140723224236.GC28485@lunn.ch> <94F87063-D717-435B-B7C5-EDAC9B26742C@perenite.com> <20140723225841.GD28485@lunn.ch> <10A7C530-7CD2-4ED0-889A-7FAC1922320F@perenite.com> <20140723231535.GK23220@titan.lakedaemon.net> <53D0FA2F.6050209@free-electrons.com> <20140724124520.GV23220@titan.lakedaemon.net> <20140724140757.GW23220@titan.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140724140757.GW23220@titan.lakedaemon.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The only outstanding point (Arnd?), is that I think it's ok to have the > i2c...a0 compatible string in the dts files, but Andrew seems to think > otherwise. Is that still true Andrew? Hi Jason I can live with i2c...a0 compatible string, but it has minor problems: 1) The binding Documentation says not to do it. So we are ignoring our own documentation. 2) It seems likely that at some point the OEM will swap to B1 revision SoCs. The i2c device then does not require this quirk, but we have hard coded in the DT file that it is required. B1 revision would work, but not optimally. So i would prefer not to explicitly enable the quirk, but determine at run time if the quirk is needed for the SoC revision it is running on. Andrew