From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/2] pinctrl: sunxi: number gpio ranges starting from 0 Date: Thu, 24 Jul 2014 18:01:41 +0200 Message-ID: <20140724160141.GZ20328@lukather> References: <1405358677-23657-1-git-send-email-wens@csie.org> <1405358677-23657-3-git-send-email-wens@csie.org> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XLRYXLjFvhZHhWey" Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Linus Walleij , linux-arm-kernel , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi List-Id: linux-gpio@vger.kernel.org --XLRYXLjFvhZHhWey Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 24, 2014 at 09:19:18PM +0800, Chen-Yu Tsai wrote: > > This patch also changes the GPIO bindings for R_PIO: > > > > gpios =3D <&r_pio B N flag>; > > > > Where B originally was the pinbank label (L or M) counted from A, > > with this patch it becomes (L or M) counted from its pinbank base (L). > > > > Thus > > > > gpios =3D <&r_pio 10 11 0>; /* PL11 */ > > > > becomes > > > > gpios =3D <&r_pio 0 11 0>; /* PL11 */ > > > > IMO this is correct, as the binding shows the bank offset and pin offset > > within the bank for the GPIO controller. But I'm worried it might be a > > bit confusing. >=20 > I see you Acked this patch, but also in your reply to my cover letter, > you mentioned that you want absolute pin numbers matching the datasheets. > What about the GPIO DT bindings, as I explained above? >=20 > Just double checking. Thanks. I'd like it to have the absolute numbers in sysfs, but the relative one in the DT. But I guess it's already what's happening, right? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --XLRYXLjFvhZHhWey Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJT0S3lAAoJEBx+YmzsjxAgt68QAI5b4a9f3nkT+G2RN7fbTwH0 H5ZJUnapwmvCCWhZijrIVo1fxnVcv+DETWWXqTlfEAzzhMUnsdD6BTMURfhwYyTm h7CSCEBAL1Y4VyqklJu2ICDTBGYnkkg0VUNN0lO9JuSwlgZM0kEwm/DRJVxO5AfW mJ12WEWJbDYKipq38SZBrxzQoSBDv09spDzM7DObTvA+OAf3m2x6+KoPP1DTplHE zf0tcBVIORgDKkFKtGCSY8LmD3PK6smL47QUV34LO6L0DrI0iBJtXv6C42IAwjmx M5SZLn6wkFTtXzt8mIqwwWvSlLGv47JGMF1TfKyPv7kTM/ohDb71jAt+E2tjEOoN 1+zSIZABo0FqiFtQx/EQGQIHTRGTb2QyxT4juBD47F1cSLhf7reK0RR+qnqvve/F zBdf/IDdPfuTcuZtb9dv9AaHPbwHnIeigjikVi+FhZJsYzRb483uYZ76a2bsY2Vi 55pxQOmaAiVV7l2TMP72+uQQfhvTP/8ByqeLhl2vuzDFlA62GvvJnBOKI/ek6boX HHKYT7dbtA0RRsFt8bghYgyoTlIAyR3/gzhNVM0Rnda/WkS9FcI7grcA5A+4UW66 PWMZOyKA6bt71hmh/Ax70eFGApLxCGMecsW3145i3AKsoAepJj2EjoJQpYJDMwF+ kt6ngBraNz+D1diDe1oQ =a75j -----END PGP SIGNATURE----- --XLRYXLjFvhZHhWey-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Thu, 24 Jul 2014 18:01:41 +0200 Subject: [PATCH 2/2] pinctrl: sunxi: number gpio ranges starting from 0 In-Reply-To: References: <1405358677-23657-1-git-send-email-wens@csie.org> <1405358677-23657-3-git-send-email-wens@csie.org> Message-ID: <20140724160141.GZ20328@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jul 24, 2014 at 09:19:18PM +0800, Chen-Yu Tsai wrote: > > This patch also changes the GPIO bindings for R_PIO: > > > > gpios = <&r_pio B N flag>; > > > > Where B originally was the pinbank label (L or M) counted from A, > > with this patch it becomes (L or M) counted from its pinbank base (L). > > > > Thus > > > > gpios = <&r_pio 10 11 0>; /* PL11 */ > > > > becomes > > > > gpios = <&r_pio 0 11 0>; /* PL11 */ > > > > IMO this is correct, as the binding shows the bank offset and pin offset > > within the bank for the GPIO controller. But I'm worried it might be a > > bit confusing. > > I see you Acked this patch, but also in your reply to my cover letter, > you mentioned that you want absolute pin numbers matching the datasheets. > What about the GPIO DT bindings, as I explained above? > > Just double checking. Thanks. I'd like it to have the absolute numbers in sysfs, but the relative one in the DT. But I guess it's already what's happening, right? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: