From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: fsl-edma: fix dmamux index calculating error
Date: Fri, 25 Jul 2014 14:12:15 +0530 [thread overview]
Message-ID: <20140725084215.GL8181@intel.com> (raw)
In-Reply-To: <1404204063-20961-1-git-send-email-jingchang.lu@freescale.com>
On Tue, Jul 01, 2014 at 04:41:03PM +0800, Jingchang Lu wrote:
> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
Applied, thanks
--
~Vinod
> ---
> drivers/dma/fsl-edma.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/fsl-edma.c b/drivers/dma/fsl-edma.c
> index b396a7f..24ab3d3 100644
> --- a/drivers/dma/fsl-edma.c
> +++ b/drivers/dma/fsl-edma.c
> @@ -248,11 +248,12 @@ static void fsl_edma_chan_mux(struct fsl_edma_chan *fsl_chan,
> unsigned int slot, bool enable)
> {
> u32 ch = fsl_chan->vchan.chan.chan_id;
> - void __iomem *muxaddr = fsl_chan->edma->muxbase[ch / DMAMUX_NR];
> + void __iomem *muxaddr;
> unsigned chans_per_mux, ch_off;
>
> chans_per_mux = fsl_chan->edma->n_chans / DMAMUX_NR;
> ch_off = fsl_chan->vchan.chan.chan_id % chans_per_mux;
> + muxaddr = fsl_chan->edma->muxbase[ch / chans_per_mux];
>
> if (enable)
> edma_writeb(fsl_chan->edma,
> @@ -724,6 +725,7 @@ static struct dma_chan *fsl_edma_xlate(struct of_phandle_args *dma_spec,
> {
> struct fsl_edma_engine *fsl_edma = ofdma->of_dma_data;
> struct dma_chan *chan, *_chan;
> + unsigned long chans_per_mux = fsl_edma->n_chans / DMAMUX_NR;
>
> if (dma_spec->args_count != 2)
> return NULL;
> @@ -732,7 +734,7 @@ static struct dma_chan *fsl_edma_xlate(struct of_phandle_args *dma_spec,
> list_for_each_entry_safe(chan, _chan, &fsl_edma->dma_dev.channels, device_node) {
> if (chan->client_count)
> continue;
> - if ((chan->chan_id / DMAMUX_NR) == dma_spec->args[0]) {
> + if ((chan->chan_id / chans_per_mux) == dma_spec->args[0]) {
> chan = dma_get_slave_channel(chan);
> if (chan) {
> chan->device->privatecnt++;
> --
> 1.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
prev parent reply other threads:[~2014-07-25 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 8:41 [PATCH] dmaengine: fsl-edma: fix dmamux index calculating error Jingchang Lu
2014-07-02 14:13 ` Stefan Agner
2014-07-25 8:42 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725084215.GL8181@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.