All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arjun AK <arjunak234@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	sparmaintainer@unisys.com, benjamin.romer@unisys.com,
	david.kershner@unisys.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH] Staging: unisys: Fix code style
Date: Fri, 25 Jul 2014 13:38:41 +0300	[thread overview]
Message-ID: <20140725103841.GV25880@mwanda> (raw)
In-Reply-To: <2159111.NPHfj36gbu@thinkpad>

On Fri, Jul 25, 2014 at 03:37:41PM +0530, Arjun AK wrote:
> >From 8e7748dd81cf63c62dbef8f102e97da1d4d5d90a Mon Sep 17 00:00:00 2001
> From: Arjun AK <arjunak234@gmail.com>
> Date: Fri, 25 Jul 2014 15:09:11 +0530
> Subject: [PATCH] Staging: unisys: Fix code style
> 
> Fixes code style in multiple files
> 
> Signed-off-by: Arjun AK <arjunak234@gmail.com>

Is your name really AK?
Does this even compile???
Read paragraph #1 of Documentation/email-clients.txt.
Break this up into patches that fix one kind of problem per patch.
Work against linux-next.

regards,
dan carpenter


  reply	other threads:[~2014-07-25 10:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 10:07 [PATCH] Staging: unisys: Fix code style Arjun AK
2014-07-25 10:38 ` Dan Carpenter [this message]
2014-07-26  6:09 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725103841.GV25880@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=arjunak234@gmail.com \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.