From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Jiří Prchal" <jiri.prchal@aksignal.cz>
Cc: Bryan Wu <cooloney@gmail.com>,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
kadlec@blackhole.kfki.hu, kaber@trash.net,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2] nf: xt_LED: fix too short led-always-blink
Date: Fri, 25 Jul 2014 14:59:16 +0200 [thread overview]
Message-ID: <20140725125916.GA13813@salvia> (raw)
In-Reply-To: <53D2504A.20003@aksignal.cz>
On Fri, Jul 25, 2014 at 02:40:42PM +0200, Jiří Prchal wrote:
> If led-always-blink is set, then between switch led OFF and ON
> is almost zero time. So blink is invisible. This use oneshot led trigger
> with fixed time 50ms witch is enough to see blink.
>
> Signed-off-by: Jiri <jiri.prchal@aksignal.cz>
>
> v2:
> defined constant XT_LED_BLINK_DELAY and use it instead of number
Strange, this doesn't apply. Perhaps your MUA is mangling the
attachment? Or using a very old tree as reference?
$ patch -p1 < /tmp/v2-nf-xt_LED-fix-too-short-led-always-blink.patch
patching file net/netfilter/xt_LED.c
Hunk #1 FAILED at 28.
Hunk #2 FAILED at 55.
Hunk #3 FAILED at 62.
3 out of 3 hunks FAILED -- saving rejects to file net/netfilter/xt_LED.c.rej
prev parent reply other threads:[~2014-07-25 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 9:17 [BUG] nf: xt_LED: led-always-blink invisible Jiří Prchal
2014-06-30 10:54 ` Pablo Neira Ayuso
2014-06-30 23:36 ` Bryan Wu
2014-07-25 7:21 ` [PATCH] nf: xt_LED: fix too short led-always-blink Jiří Prchal
2014-07-25 12:22 ` Pablo Neira Ayuso
2014-07-25 12:40 ` [PATCH v2] " Jiří Prchal
2014-07-25 12:59 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725125916.GA13813@salvia \
--to=pablo@netfilter.org \
--cc=cooloney@gmail.com \
--cc=coreteam@netfilter.org \
--cc=jiri.prchal@aksignal.cz \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-leds@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.