All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: cheng wei Lin <dusonlin@emc.com.tw>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	bleung@chromium.org, agnescheng@chromium.org,
	"\"SRD1
	&#65533;蝬踐&#65533;&#65533;?都&#65533;&#65533;&#65533;&#65533;\""
	<phoenix@emc.com.tw>,
	jeff.chuang@emc.com.tw
Subject: Re: [PATCH v2] Input: add i2c/smbus driver for elan touchpad
Date: Fri, 25 Jul 2014 13:06:56 -0700	[thread overview]
Message-ID: <20140725200656.GA2827@core.coreip.homeip.net> (raw)
In-Reply-To: <20140725182053.GA23356@core.coreip.homeip.net>

On Fri, Jul 25, 2014 at 11:20:53AM -0700, Dmitry Torokhov wrote:
> Hi Duson,
> 
> On Sat, Jul 26, 2014 at 02:05:02AM +0800, cheng wei Lin wrote:
> > Hi Dmitry,
> > 
> > Sorry for late to reply you and thanks for your command
> > 
> > Yes, I also agree, it looks great than my original code.
> 
> Thank you for confirming.
> 
> > So, should I modify this and upstream v3 patch for you?
> 
> No, that is fine, I'll fix it up on my end.

Hmm, I am also looking at elan_get_x_resolution() and in case of SMB
we'll never get negative result since we are doing
"elan_convert_res(val[1] & 0x0F)". Was it intended as such, or do we
need to extend sign here via

	(((char)(val[1] & 0x0F)) << 4) >> 4;

Thanks.

-- 
Dmitry

  reply	other threads:[~2014-07-25 20:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07  3:08 [PATCH v2] Input: add i2c/smbus driver for elan touchpad Duson Lin
2014-01-07  3:08 ` Duson Lin
2014-01-10 20:30 ` Benson Leung
2014-02-07  0:21   ` Benson Leung
2014-02-19 21:48     ` Benson Leung
2014-07-24 18:05 ` Dmitry Torokhov
2014-07-25 18:05   ` cheng wei Lin
2014-07-25 18:05     ` cheng wei Lin
2014-07-25 18:20     ` Dmitry Torokhov
2014-07-25 20:06       ` Dmitry Torokhov [this message]
2014-07-26  8:12         ` cheng wei Lin
2014-07-26  8:12           ` cheng wei Lin
2014-10-03 21:03 ` Dmitry Torokhov
2014-10-03 21:03   ` Dmitry Torokhov
2014-10-03 21:06   ` Dmitry Torokhov
2014-10-03 21:06     ` Dmitry Torokhov
2014-10-06  9:24     ` Mark Rutland
2014-10-06 16:37       ` Dmitry Torokhov
2014-10-07  1:15         ` duson
     [not found]           ` <4D9D80FFD7AF42848710DF158445E41B-/M1eSjm1S/B4Eiagz67IpQ@public.gmane.org>
2014-10-07  1:24             ` 'Dmitry Torokhov'
2014-10-03 21:30   ` Benson Leung
  -- strict thread matches above, loose matches on Subject: below --
2013-12-18  3:46 Duson Lin
2014-02-07  0:10 ` Benson Leung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725200656.GA2827@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=agnescheng@chromium.org \
    --cc=bleung@chromium.org \
    --cc=dusonlin@emc.com.tw \
    --cc=jeff.chuang@emc.com.tw \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phoenix@emc.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.