From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XAt4x-0004Et-Hc for mharc-grub-devel@gnu.org; Fri, 25 Jul 2014 23:55:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAt4m-00047A-I7 for grub-devel@gnu.org; Fri, 25 Jul 2014 23:55:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAt4d-0005Pn-GG for grub-devel@gnu.org; Fri, 25 Jul 2014 23:55:16 -0400 Received: from mail-la0-x22f.google.com ([2a00:1450:4010:c03::22f]:42571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAt4d-0005N1-7V for grub-devel@gnu.org; Fri, 25 Jul 2014 23:55:07 -0400 Received: by mail-la0-f47.google.com with SMTP id mc6so3619605lab.6 for ; Fri, 25 Jul 2014 20:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=6I0kIqteCBJ1v8VdrV2V3Mpuy6evp/wC9E73Yv1URg0=; b=ha431DbyLZja6CIQXJ8DphwdH8bNpS/oykS8CyYqolTA7ZXNWB08tEWWpD/TXa0R12 gbgMmdDnq19773gEFDpOAwsiN4JOsexvE+R/YVVKE4HwZgxZFmQVWAES9325x1zY62/r Qe0jUWSKc3rCB3S2tX7VYAWN+nXHSfKcwUVNaViHq9FHERs+yJb9MDldRqrej57pyDwl b+CS53z8T8kdOO213N1hMcF5BSxVeMtjG8FPYvGiCfCU7OVKaqTVMT8PGaioIc4SSblT y6C8dOzZjIIGvv++r9RW7XhjWvB8xa9XCt8YGnqWgY2YU1rejTXJ2pafWcB4FcrHoAjg 29rw== X-Received: by 10.112.181.74 with SMTP id du10mr19344947lbc.40.1406346905813; Fri, 25 Jul 2014 20:55:05 -0700 (PDT) Received: from opensuse.site (ppp94-29-76-101.pppoe.spdop.ru. [94.29.76.101]) by mx.google.com with ESMTPSA id kj8sm19123792lbc.10.2014.07.25.20.55.04 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 25 Jul 2014 20:55:04 -0700 (PDT) Date: Sat, 26 Jul 2014 07:55:03 +0400 From: Andrey Borzenkov To: The development of GNU GRUB Subject: Re: [PATCH] fix PXE transmit failure if P_UNKNOWN is not supported Message-ID: <20140726075503.38bd2db7@opensuse.site> In-Reply-To: <53D2CE5A.2040102@gmail.com> References: <1406303622-31501-1-git-send-email-arvidjaar@gmail.com> <53D2CE5A.2040102@gmail.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/OiKhDtC.G/w_xgCvzCUAagF"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22f Cc: phcoder@gmail.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2014 03:55:25 -0000 --Sig_/OiKhDtC.G/w_xgCvzCUAagF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =D0=92 Fri, 25 Jul 2014 23:38:34 +0200 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 25.07.2014 17:53, Andrey Borzenkov wrote: > > Some PXE stacks do not support P_UNKNOWN in UNDI TRANSMIT; nothing is > > sent at all. So strip Ethernet header for known frame types and let PXE > > stack add it. > >=20 > If I'm reading this patch correctly it discards several fields of the > packet and i.a. kills vlan fields. No, it does not. It discards Ethernet headers only when packet type is IP or ARP. VLAN packet will have different type and will be passed through as happens currently. > Such low in the stack it should > replace the header only in the case of perfect match. It will be perfect > match in 99% of configs but we shouldn0t break configs on unaffected > machines. --Sig_/OiKhDtC.G/w_xgCvzCUAagF Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlPTJpcACgkQR6LMutpd94zEUgCeON2LNtibJ/tApWg2OU8Zkxv6 yikAni3SJ1wLQLKfFHy7yzOYJ9X8x9qT =7N9M -----END PGP SIGNATURE----- --Sig_/OiKhDtC.G/w_xgCvzCUAagF--