From: Kirill Tkhai <tkhai@yandex.ru>
To: linux-kernel@vger.kernel.org
Cc: nicolas.pitre@linaro.org, peterz@infradead.org, pjt@google.com,
oleg@redhat.com, rostedt@goodmis.org, umgwanakikbuti@gmail.com,
ktkhai@parallels.com, tim.c.chen@linux.intel.com,
mingo@kernel.org
Subject: [PATCH v2 0/5] sched: Add on_rq states and remove several double rq locks
Date: Sat, 26 Jul 2014 18:58:48 +0400 [thread overview]
Message-ID: <20140726145508.6308.69121.stgit@localhost> (raw)
This series aims to get rid of some places where locks of two RQs are held
at the same time.
Patch [1/5] is a preparation/cleanup. It replaces old (.on_rq == 1) with new
(.on_rq == ONRQ_QUEUED) everywhere. No functional changes.
Patch [2/5] is main in the series. It introduces new state: ONRQ_MIGRATING
and teaches scheduler to understand it (we need a little changes predominantly
in try_to_wake_up()). This will be used in the following way:
(we are changing task's rq)
raw_spin_lock(&src_rq->lock);
dequeue_task(src_rq, p, 0);
p->on_rq = ONRQ_MIGRATING;
set_task_cpu(p, dst_cpu);
raw_spin_unlock(&src_rq->lock);
raw_spin_lock(&dst_rq->lock);
p->on_rq = ONRQ_QUEUED;
enqueue_task(dst_rq, p, 0);
raw_spin_unlock(&dst_rq->lock);
Patches [3-5/5] remove double locks and use new ONRQ_MIGRATING state.
They allow unlocked using of 3-4 function, which looks safe for me.
The series doesn't add any overhead, and it shouldn't worsen performance,
I think. It improves granularity, and it's possible to imagine situations,
which will be happier without double rq lock.
v2: Changes in [2/5] and [5/5].
---
Kirill Tkhai (5):
sched: Wrapper for checking task_struct's .on_rq
sched: Teach scheduler to understand ONRQ_MIGRATING state
sched: Remove double_rq_lock() from __migrate_task()
sched/fair: Remove double_lock_balance() from active_load_balance_cpu_stop()
sched/fair: Remove double_lock_balance() from load_balance()
kernel/sched/core.c | 123 +++++++++++++++++++++++--------------
kernel/sched/deadline.c | 14 ++--
kernel/sched/fair.c | 155 ++++++++++++++++++++++++++++++----------------
kernel/sched/rt.c | 16 ++---
kernel/sched/sched.h | 13 ++++
kernel/sched/stop_task.c | 2 -
6 files changed, 206 insertions(+), 117 deletions(-)
--
Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
next reply other threads:[~2014-07-26 14:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 14:58 Kirill Tkhai [this message]
2014-07-26 14:59 ` [PATCH v2 1/5] sched: Wrapper for checking task_struct's .on_rq Kirill Tkhai
2014-07-26 14:59 ` [PATCH v2 2/5] sched: Teach scheduler to understand ONRQ_MIGRATING state Kirill Tkhai
2014-07-28 8:01 ` Peter Zijlstra
2014-07-28 9:05 ` Kirill Tkhai
2014-07-29 9:53 ` Kirill Tkhai
2014-07-29 12:38 ` Peter Zijlstra
2014-07-29 16:19 ` Oleg Nesterov
2014-07-30 8:04 ` Kirill Tkhai
2014-07-30 14:41 ` Oleg Nesterov
2014-07-30 21:25 ` Kirill Tkhai
2014-07-26 14:59 ` [PATCH v2 3/5] sched: Remove double_rq_lock() from __migrate_task() Kirill Tkhai
2014-07-26 14:59 ` [PATCH v2 4/5] sched/fair: Remove double_lock_balance() from active_load_balance_cpu_stop() Kirill Tkhai
2014-07-26 14:59 ` [PATCH v2 5/5] sched/fair: Remove double_lock_balance() from load_balance() Kirill Tkhai
2014-07-29 12:57 ` Peter Zijlstra
2014-07-26 19:39 ` [PATCH v2 0/5] sched: Add on_rq states and remove several double rq locks Oleg Nesterov
2014-07-27 21:26 ` Kirill Tkhai
2014-07-28 13:19 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140726145508.6308.69121.stgit@localhost \
--to=tkhai@yandex.ru \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.