All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] ext4: fix incorrect locking in move_extent_per_page
Date: Sun, 27 Jul 2014 22:33:18 -0400	[thread overview]
Message-ID: <20140728023318.GK6725@thunk.org> (raw)
In-Reply-To: <20140721195102.GC19942@quack.suse.cz>

On Mon, Jul 21, 2014 at 09:51:02PM +0200, Jan Kara wrote:
> On Mon 21-07-14 19:04:49, Dmitry Monakhov wrote:
> > If we have to copy data we must drop i_data_sem because of
> > get_blocks() will be called inside mext_page_mkuptodate(), but later we must
> > reacquire it again because we are about to change extent's tree
> > 
> > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>   Looks good. You can add:
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks, applied.

					- Ted

  reply	other threads:[~2014-07-28  2:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 15:04 [PATCH 1/3] ext4: add i_data_sem sanity check Dmitry Monakhov
2014-07-21 15:04 ` [PATCH 2/3] ext4: use correct depth value Dmitry Monakhov
2014-07-21 19:48   ` Jan Kara
2014-07-28  2:31     ` Theodore Ts'o
2014-07-21 15:04 ` [PATCH 3/3] ext4: fix incorrect locking in move_extent_per_page Dmitry Monakhov
2014-07-21 19:51   ` Jan Kara
2014-07-28  2:33     ` Theodore Ts'o [this message]
2014-07-21 19:35 ` [PATCH 1/3] ext4: add i_data_sem sanity check Jan Kara
2014-07-28  2:29   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140728023318.GK6725@thunk.org \
    --to=tytso@mit.edu \
    --cc=dmonakhov@openvz.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.