From: Florian Westphal <fw@strlen.de>
To: David Miller <davem@davemloft.net>
Cc: nikolay@redhat.com, netdev@vger.kernel.org, fw@strlen.de,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, alex.aring@gmail.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 0/9] inet: frag: cleanup and update
Date: Mon, 28 Jul 2014 10:00:49 +0200 [thread overview]
Message-ID: <20140728080049.GC28720@breakpoint.cc> (raw)
In-Reply-To: <20140727.223718.1055588669834128686.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Nikolay Aleksandrov <nikolay@redhat.com>
> Date: Thu, 24 Jul 2014 16:50:28 +0200
>
> > The end goal of this patchset is to remove the LRU list and to move the
> > frag eviction to a work queue. It also does a couple of necessary cleanups
> > and fixes. Brief patch descriptions:
>
> Ok I decided to apply this series.
>
> Honestly I thought the frag counter would be useful for diagnosing problems
> ("are there a lot of frag queues bunched up on my machine?"). But whatever.
>
> You could make it accurate again by just scanning the hash table really
> quickly and counting how many entries you see, if you wanted to.
Right. In case someone reports a bug vs. "bogus frag counter" either
myself or Nik will submit a patch to do this.
Thanks David.
next prev parent reply other threads:[~2014-07-28 8:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 14:50 [PATCH net-next 0/9] inet: frag: cleanup and update Nikolay Aleksandrov
2014-07-24 14:50 ` [PATCH net-next 1/9] inet: frag: constify match, hashfn and constructor arguments Nikolay Aleksandrov
2014-07-24 14:50 ` [PATCH net-next 2/9] inet: frag: remove hash size assumptions from callers Nikolay Aleksandrov
2014-07-24 14:50 ` [PATCH net-next 3/9] inet: frag: move evictor calls into frag_find function Nikolay Aleksandrov
2014-07-24 14:50 ` [PATCH net-next 4/9] inet: frag: move eviction of queues to work queue Nikolay Aleksandrov
2014-07-24 14:50 ` [PATCH net-next 5/9] inet: frag: don't account number of fragment queues Nikolay Aleksandrov
2014-07-25 6:15 ` David Miller
2014-07-25 8:32 ` Florian Westphal
2014-07-24 14:50 ` [PATCH net-next 6/9] inet: frag: remove lru list Nikolay Aleksandrov
2014-07-24 14:50 ` [PATCH net-next 7/9] inet: frag: remove periodic secret rebuild timer Nikolay Aleksandrov
2014-07-24 14:50 ` [PATCH net-next 8/9] inet: frag: use seqlock for hash rebuild Nikolay Aleksandrov
2014-07-24 14:50 ` [PATCH net-next 9/9] inet: frag: set limits and make init_net's high_thresh limit global Nikolay Aleksandrov
2014-07-28 5:37 ` [PATCH net-next 0/9] inet: frag: cleanup and update David Miller
2014-07-28 8:00 ` Florian Westphal [this message]
2014-07-28 6:43 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728080049.GC28720@breakpoint.cc \
--to=fw@strlen.de \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.