diff for duplicates of <20140728093611.GA3975@node.dhcp.inet.fi> diff --git a/a/1.txt b/N1/1.txt index 00c951f..d7a37b3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -77,43 +77,3 @@ badly if fault_around_bytes will be changed under do_fault_around()... I don't think it worth adding the serialization to hot path to protect against debug interface. Any thoughts? - ->From 2932fbcefe4ec21c046348e21981149ecce5d161 Mon Sep 17 00:00:00 2001 -From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> -Date: Mon, 28 Jul 2014 12:16:49 +0300 -Subject: [PATCH] mm, debugfs: workaround undefined behaviour of - rounddown_pow_of_two(0) - -Result of rounddown_pow_of_two(0) is not defined. It can cause a bug if -user will set fault_around_bytes to 0 via debugfs interface. - -Let's set fault_around_bytes to PAGE_SIZE if user tries to set it to -something below PAGE_SIZE. - -Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> ---- - mm/memory.c | 3 ++- - 1 file changed, 2 insertions(+), 1 deletion(-) - -diff --git a/mm/memory.c b/mm/memory.c -index 7e8d8205b610..2d8fa7a7b0ee 100644 ---- a/mm/memory.c -+++ b/mm/memory.c -@@ -2786,7 +2786,8 @@ static int fault_around_bytes_set(void *data, u64 val) - { - if (val / PAGE_SIZE > PTRS_PER_PTE) - return -EINVAL; -- fault_around_bytes = val; -+ /* rounddown_pow_of_two(0) is not defined */ -+ fault_around_bytes = max(val, PAGE_SIZE); - return 0; - } - DEFINE_SIMPLE_ATTRIBUTE(fault_around_bytes_fops, --- - Kirill A. Shutemov - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 92c7ed5..1d19125 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -103,46 +103,6 @@ "\n" "I don't think it worth adding the serialization to hot path to protect\n" "against debug interface.\n" - "Any thoughts?\n" - "\n" - ">From 2932fbcefe4ec21c046348e21981149ecce5d161 Mon Sep 17 00:00:00 2001\n" - "From: \"Kirill A. Shutemov\" <kirill.shutemov@linux.intel.com>\n" - "Date: Mon, 28 Jul 2014 12:16:49 +0300\n" - "Subject: [PATCH] mm, debugfs: workaround undefined behaviour of\n" - " rounddown_pow_of_two(0)\n" - "\n" - "Result of rounddown_pow_of_two(0) is not defined. It can cause a bug if\n" - "user will set fault_around_bytes to 0 via debugfs interface.\n" - "\n" - "Let's set fault_around_bytes to PAGE_SIZE if user tries to set it to\n" - "something below PAGE_SIZE.\n" - "\n" - "Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>\n" - "---\n" - " mm/memory.c | 3 ++-\n" - " 1 file changed, 2 insertions(+), 1 deletion(-)\n" - "\n" - "diff --git a/mm/memory.c b/mm/memory.c\n" - "index 7e8d8205b610..2d8fa7a7b0ee 100644\n" - "--- a/mm/memory.c\n" - "+++ b/mm/memory.c\n" - "@@ -2786,7 +2786,8 @@ static int fault_around_bytes_set(void *data, u64 val)\n" - " {\n" - " \tif (val / PAGE_SIZE > PTRS_PER_PTE)\n" - " \t\treturn -EINVAL;\n" - "-\tfault_around_bytes = val;\n" - "+\t/* rounddown_pow_of_two(0) is not defined */\n" - "+\tfault_around_bytes = max(val, PAGE_SIZE);\n" - " \treturn 0;\n" - " }\n" - " DEFINE_SIMPLE_ATTRIBUTE(fault_around_bytes_fops,\n" - "-- \n" - " Kirill A. Shutemov\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + Any thoughts? -c890734430de97e96f14aea2995f4ec3c4b5060a2ac01e6b64d4cba084e781f6 +bf11746c5f784c608dd5d5c3e686e62e04de9cfe95c7dec717c70bb020853d0e
diff --git a/a/1.txt b/N2/1.txt index 00c951f..a0c8899 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -111,9 +111,3 @@ index 7e8d8205b610..2d8fa7a7b0ee 100644 DEFINE_SIMPLE_ATTRIBUTE(fault_around_bytes_fops, -- Kirill A. Shutemov - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index 92c7ed5..e93373f 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -137,12 +137,6 @@ " }\n" " DEFINE_SIMPLE_ATTRIBUTE(fault_around_bytes_fops,\n" "-- \n" - " Kirill A. Shutemov\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + Kirill A. Shutemov -c890734430de97e96f14aea2995f4ec3c4b5060a2ac01e6b64d4cba084e781f6 +eff65458786dd7a27101a5eaf11058a42cb1d60b90e59a6a7abc8ec0c00464f6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.