All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: jslaby@suse.cz, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: serial_core.c: printk replacement
Date: Mon, 28 Jul 2014 08:21:11 -0700	[thread overview]
Message-ID: <20140728152111.GA13149@kroah.com> (raw)
In-Reply-To: <1406559481-14084-1-git-send-email-sudipm.mukherjee@gmail.com>

On Mon, Jul 28, 2014 at 08:28:01PM +0530, Sudip Mukherjee wrote:
> printk replaced with corresponding pr_* 
> fixed two broken user-visible strings used by the printk

Can you change to use dev_err() instead?  That would help identify the
device and driver causing this problem better.

thanks,

greg k-h

  reply	other threads:[~2014-07-28 15:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 14:58 [PATCH] tty: serial: serial_core.c: printk replacement Sudip Mukherjee
2014-07-28 15:21 ` Greg KH [this message]
     [not found] <[PATCH] tty: serial: serial_core.c: printk replacement>
2014-07-30 14:07 ` Sudip Mukherjee
2014-07-30 14:37   ` Jiri Slaby
2014-07-30 14:52     ` Sudip Mukherjee
2014-07-31 13:50       ` Sudip Mukherjee
  -- strict thread matches above, loose matches on Subject: below --
2014-08-05 12:35 Sudip Mukherjee
2014-08-18 12:25 ` Jiri Slaby
2014-08-19  5:36   ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140728152111.GA13149@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.